Agent activity reorder follow-ups: group on-top check, search, subtitle - #15362
Conversation
- isAtTopOfUnpinnedTier requires a group member to lead its group, the slot a notification bump promotes it to, so the gate no longer skips the in-group move. - Settings search finds the reorder setting by agent activity terms. - The subtitle, schema and settings reference mention that a new prompt also moves the row (all 19 locales). - Remove the unused WorkspaceActivityReorderGate.forget(workspaceId:). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
All contributors have signed the CLA ✍️ ✅ |
|
Dogfood build of cmux DEV pr-15362-1e1e7e24.app The link opens this exact commit in the cmux dev menu bar app. The build starts on each push and the page waits until it is ready; a newer push replaces it. It signs in against production, so Cloud or backend changes still need a tagged build with a development backend. Dogfood tours of
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
💤 Files with no reviewable changes (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe changes update how grouped workspaces qualify as first in the unpinned tier, remove a workspace activity reorder gate method and its test, and revise the Reorder on Notification setting’s descriptions and search terms. ChangesWorkspace notification reordering
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue remains from the available evidence. The change is mergeable after normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change can alter when a grouped workspace row moves, but the inspected flow retains its existing pinned, selected, and interaction checks. No new privileged action was identified. Some execution and security coverage remains incomplete. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error, 1 warning)
✅ Passed checks (23 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 5 files. (3 skipped: 3 unsupported.) Full details: Cmux Full InternationalizationExplanation The PR changes user-facing web metadata without locale-specific coverage. Resolution Add a stable
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
CI failure attributionCI passes on Written by |
The PR media tour selector (#15280) requires every checked-in tour to declare the paths that pick it; this tour predates that rule. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
…r-nits # Conflicts: # dogfood/scenarios/agent-activity-reorder.json
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Merge receipt for |
0e298fb ci: wait for the product's canonical root instead of compiling beside it (manaflow-ai#15379) 3088273 ci: UI test runs adopt compile admission's product, skip the re-upload, and report progress (manaflow-ai#15331) b681e7e Keep a pending banner quiet once its pane is focused (manaflow-ai#15357) 03a2f6e Record that cloud_vm_sessions.attachment_count is cumulative (manaflow-ai#15321) 48258b4 fix(iroh-v2): check the team socket cap before opening the session (manaflow-ai#15340) 2638d56 Agent activity reorder follow-ups: group on-top check, search, subtitle (manaflow-ai#15362) 9ed83fd Dogfood journey: record whether a paused Cloud machine is asleep (manaflow-ai#15293) 7171ea8 Add app.tabBarVisibility to hide the pane tab bar when a pane has one tab (manaflow-ai#15294) 8743ec8 test: stop Computer Use onboarding tests waiting out the helper status deadline (manaflow-ai#15329) 6e4f1da ci: drain the snapshot's owned queue by what the machines finished since (manaflow-ai#15374) 9373164 ci: queue a pull request's admission for a root runner when Blacksmith's wait is longer (manaflow-ai#15376) 634a155 test: expect injected pane attention accent (manaflow-ai#15370) cd030e9 Keep a named Cloud machine's prompt name instead of flipping to its slug (manaflow-ai#15288) 24ee0ee Exit 1 when cmux terminal screen wait times out (manaflow-ai#15282) 1b857ac test: cover a live Codex turn owner keeping its turn on SessionStart (manaflow-ai#13588) 56ec600 PR media: prune media of long-closed pull requests (manaflow-ai#15364) 4898cde ci: bound the SwiftPM scratch holder and cache scratch sizes (manaflow-ai#15366) # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci.yml # .github/workflows/test-e2e.yml
1 participant
Summary
Follow-ups from the review of #15216 (RFC #15202):
WorkspaceReorderCoordinator.isAtTopOfUnpinnedTieronly looked at the top-level row, so a member deep inside a group that sits first counted as on top. The agent-activity gate then skipped the in-group move thatmoveTabToTopForNotificationwould make. A group member now counts as on top only when its group is first and it is the first member after the anchor, which is the slot a notification bump promotes it to. Pinned members of an unpinned group are skipped, since the bump keeps them ahead of promoted members.SettingsSearchAliases, curated synonyms, and every locale's alias string) now include agent activity terms (agent, activity, prompt, turn, finished, needs input), plus Japanese terms.WorkspaceActivityReorderGate.forget(workspaceId:)and its test. Expired moves are already pruned and closed workspaces are dropped on drain.No behavior change in the default
notificationsmode.Testing
WorkspaceCoordinatorTests.isAtTopOfUnpinnedTierRequiresAGroupMemberToLeadItsGroup: the anchor and first member count as on top, a later member does not, and after a notification bump the promoted member does.localization_catalog.py checkandlocalize_changes.pypass; the schema was regenerated withgenerate-cmux-config-schema.py.Changelog
Changed: Settings search finds Reorder on Notification by agent activity terms, and its description mentions that sending a prompt also moves the workspace in Agent Activity mode
🤖 Generated with Claude Code