dogfood: give the agent activity reorder tour paths globs by lawrencecchen · Pull Request #15360 · manaflow-ai/cmux

lawrencecchen · 2026-09-28T12:18:45Z

Summary

#15216 added dogfood/scenarios/agent-activity-reorder.json without paths globs. The tour validity test test_checked_in_tours_are_valid_and_the_default_exists in guards / workflow-guard-tests / app-host-execution fails with agent-activity-reorder.json has no paths globs. That failure makes the macOS admission gate stop before compiling, so every PR is blocked (seen on #15198).

This adds globs for the reorder feature's source: Sources/Sidebar/*Reorder*, Sources/AgentJournalLifecycleCenter*, Packages/macOS/CmuxWorkspaces/* and Packages/macOS/CmuxAgentJournal/*.

Testing

uv run --with pyyaml python tests/test_ci_pr_media.py: 33 tests OK (1 skipped). Before the change, the same test failed.

Changelog

none

🤖 Generated with Claude Code

Summary by cubic

Adds paths globs for the agent activity reorder feature's source files to dogfood/scenarios/agent-activity-reorder.json, fixing the tour validity test failure (agent-activity-reorder.json has no paths globs) that was blocking the macOS admission gate on every PR before compilation.

^{Written for commit 61cb263. Summary will update on new commits.}

Summary by CodeRabbit

Tests
- Expanded the agent activity reorder scenario to cover additional sidebar, journal, and macOS workspace paths. The launch configuration and scenario steps remain unchanged.

#15216 added agent-activity-reorder.json without paths, so the tour validity test in workflow-guard-tests/app-host-execution fails on every PR and the macOS admission gate stops before compiling. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

cursor · 2026-09-28T12:18:50Z

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

github-actions · 2026-09-28T12:18:59Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

coderabbitai · 2026-09-28T12:19:32Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 073edf33-d62d-49bb-b192-6463b2cc7a3b

📥 Commits

Reviewing files that changed from the base of the PR and between 558d6b9 and 61cb263.

📒 Files selected for processing (1)

dogfood/scenarios/agent-activity-reorder.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The agent activity reorder scenario adds four reorder-related source and package paths to its paths list. The launch configuration and scenario steps remain unchanged.

Changes

Agent activity reorder scenario

Layer / File(s)	Summary
Add reorder-related paths `dogfood/scenarios/agent-activity-reorder.json`	The `paths` list adds globs for sidebar reorder code, the agent journal lifecycle center, and the macOS workspace and agent journal packages.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Suggested reviewers: teamleaderleo

Merge Risk: ⚪ Minimal · up to 61cb2

The scenario is selected for its own change and covers the inspected reorder paths, so no actionable merge-blocking risk is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to 61cb2

The change affects 1 system.

Changed systems: dogfood

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — dogfood (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in dogfood/scenarios/agent-activity-reorder.json: The scenario’s paths list was added with four reorder-related source and package globs.

🚥 Pre-merge checks | ✅ 25

✅ Passed checks (25 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding path globs for the agent activity reorder tour scenario.
Description check	✅ Passed	The description includes a clear Summary, Testing results, and Changelog entry. It explains the failing validation, the added globs, and the test command and result. The Demo Video and Checklist secti…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input	✅ Passed	The pull request changes only `dogfood/scenarios/agent-activity-reorder.json` by adding four `paths` globs. It does not change Cloud terminal creation, transport, renderer admission, input routing, au…
Cmux Swift Actor Isolation	✅ Passed	PASS: The pull request changes only dogfood/scenarios/agent-activity-reorder.json. The diff adds four path globs and contains no Swift files or production Swift source changes. The Swift actor isolati…
Cmux Swift Blocking Runtime	✅ Passed	The pull request changes only `dogfood/scenarios/agent-activity-reorder.json`. The diff adds path globs and contains no Swift changes or blocking or timing-based synchronization.
Cmux Browser Automation Off-Main	✅ Passed	The pull request changes only `dogfood/scenarios/agent-activity-reorder.json`. The diff adds four `paths` globs and does not change browser socket commands, `Sources/TerminalController.swift`, or `Con…
Cmux Expensive Synchronous Load	✅ Passed	PASS: The authoritative PR diff changes only `dogfood/scenarios/agent-activity-reorder.json`. It adds four path-glob strings and changes no production Swift files, synchronous loads, or call sites. Th…
Cmux Cache Substitution Correctness	✅ Passed	The pull request changes only `dogfood/scenarios/agent-activity-reorder.json`. It adds four `paths` globs and does not change production Swift, TypeScript, or JavaScript code, persistence, history, un…
Cmux No Hacky Sleeps	✅ Passed	PASS. The PR changes only `dogfood/scenarios/agent-activity-reorder.json` by adding four `paths` glob entries. It does not modify TypeScript, JavaScript, shell, or runtime code. The scenario's existin…
Cmux Algorithmic Complexity	✅ Passed	PASS: The pull request changes only `dogfood/scenarios/agent-activity-reorder.json` by adding four path-glob strings. It does not change production Swift, TypeScript, JavaScript, shell, or runtime cod…
Cmux Swift Concurrency	✅ Passed	PASS: The pull request changes only `dogfood/scenarios/agent-activity-reorder.json`. The diff adds four path globs and contains no Swift files or Swift concurrency patterns.
Cmux Swift `@Concurrent`	✅ Passed	PASS: The pull request changes only `dogfood/scenarios/agent-activity-reorder.json`. The diff contains no Swift source or Swift package changes, so the `@concurrent` check is not applicable.
Cmux Swift Package Boundaries	✅ Passed	The PR changes only `dogfood/scenarios/agent-activity-reorder.json`. The diff contains no Swift, package manifest, or Xcode project changes, so the Swift package boundary check is not applicable.
Cmux Swiftpm Lockfiles	✅ Passed	PASS: The pull request changes only `dogfood/scenarios/agent-activity-reorder.json` by adding scenario path globs. It does not change a `Package.swift`, Xcode project package reference, `.gitignore`, …
Cmux Swift Logging	✅ Passed	PASS. The review range changes only `dogfood/scenarios/agent-activity-reorder.json`. The diff adds four path-glob strings and no Swift code or logging calls. The JSON parses successfully.
Cmux User-Facing Error Privacy	✅ Passed	PASS. The PR changes only `dogfood/scenarios/agent-activity-reorder.json` by adding four `paths` glob entries. The file is a checked-in dogfood scenario used by CI tour validation, and the patch adds …
Cmux Full Internationalization	✅ Passed	PASS: The PR changes only `dogfood/scenarios/agent-activity-reorder.json` and adds four source/package path globs. It adds no user-facing Swift or web text, localization keys, catalogs, locale files, …
Cmux Swiftui State Layout	✅ Passed	PASS: The pull request changes only `dogfood/scenarios/agent-activity-reorder.json` by adding path globs. It contains no SwiftUI or Swift source changes, so the SwiftUI state-layout rules do not apply…
Cmux Architecture Rethink	✅ Passed	PASS: The pull request changes only `dogfood/scenarios/agent-activity-reorder.json`. It adds path globs and does not change Swift code, lifecycle ownership, state handling, timing, locks, observers, s…
Cmux Swift Auxiliary Window Close Shortcuts	✅ Passed	The pull request changes only `dogfood/scenarios/agent-activity-reorder.json`. The diff adds path globs and contains no Swift files or window implementation changes. The auxiliary-window close-shortcu…
Cmux Source Artifacts	✅ Passed	The PR changes only `dogfood/scenarios/agent-activity-reorder.json`. The diff adds intentional scenario configuration with source-path globs. The file is tracked as a normal JSON file, parses successf…
Cmux No Test Or Debug Seam In Production Source	✅ Passed	PASS: The pull request changes only `dogfood/scenarios/agent-activity-reorder.json`. The diff contains no Swift files under a production `Sources/` path, so it cannot introduce a test or debug seam in…

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-28T12:20:11Z

Dogfood build of 61cb263c22fbdbfa0b8c27b72a069c81f4198101

cmux DEV pr-15360-61cb263c.app

The link opens this exact commit in the cmux dev menu bar app. The build starts on each push and the page waits until it is ready; a newer push replaces it. It signs in against production, so Cloud or backend changes still need a tagged build with a development backend.

Same change as #15360, carried here so this branch's Linux guard passes until that lands. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

teamleaderleo · 2026-09-28T12:44:23Z

This one unblocks three PRs of mine (#15221, #15259, #15325). They all touch
dogfood/scenarios/, which selects the media guard suite, and then
test_ci_pr_media fails on agent-activity-reorder.json having no paths
globs. Nothing to change on my side, the fix is exactly this. Green and clean
here, so whenever you are ready :)

github-actions · 2026-09-28T12:59:41Z

Merge receipt for 61cb263c22: every check was green at merge (16 verified; 16 skipped by policy). Full suite runs on main after merge.

7b6ad14 PR media: tour-only pushes load the earlier build of the same inputs (manaflow-ai#15361) 842d580 ci: prebuild selected Swift packages in parallel before the serial test pass (manaflow-ai#15114) 1a7467a dogfood: give the agent activity reorder tour paths globs (manaflow-ai#15360) 31b2619 Recover routed Claude sessions through cmux restore; journal closed panes (manaflow-ai#15324) 5a3ca1a ci: price mini contention in distance routing and keep SwiftPM builds on owned Macs (manaflow-ai#14804) b8afe20 Add notifications.suppressWhenAppFocused setting (manaflow-ai#14701) 3843dd6 ci: queue main's whole full-suite run on the owned pool (manaflow-ai#15356) # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/pr-media.yml # .github/workflows/test-e2e.yml

…width-setting Picks up #15360, which gives the agent activity reorder tour its paths globs. Without it SelectToursTests fails on every branch that merges main, and that declines macOS admission before any macOS lane runs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Picks up #15360, which gives the agent activity reorder tour its paths globs. Without it SelectToursTests fails on every branch that merges main, and that declines macOS admission before any macOS lane runs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

This was referenced Sep 28, 2026

Cmd-click bare GitHub issue, PR, and commit references in the terminal #15221

Open

Show the cmd-hover affordance over GitHub references #15259

Open

feat(terminal): right-click a link to choose where it opens #15325

Merged

teamleaderleo merged commit 1a7467a into main Sep 28, 2026
64 checks passed

teamleaderleo deleted the feat-fix-agent-reorder-tour-paths branch September 28, 2026 12:59

austinywang mentioned this pull request Sep 28, 2026

Allow terminal links to open browser tabs in the same pane #12806

Open

teamleaderleo mentioned this pull request Sep 28, 2026

Add sidebar.leftMinWidth to cmux.json #15349

Open

teamleaderleo mentioned this pull request Sep 28, 2026

Show opt-in model, context %, and estimated cost next to agent status in the sidebar #14855

Merged

austinywang mentioned this pull request Sep 28, 2026

Make Cloud Delete Machine optimistic #15190

Merged

3 tasks done

teamleaderleo mentioned this pull request Sep 28, 2026

Sidebar footer: native Help and account menus, grouped Help, stable footer #14893

Open

github-actions Bot mentioned this pull request Sep 28, 2026

Main full-suite CI is red #15404

Closed

Navigation Menu

Uh oh!

dogfood: give the agent activity reorder tour paths globs - #15360

dogfood: give the agent activity reorder tour paths globs#15360
teamleaderleo merged 1 commit into
mainfrom
feat-fix-agent-reorder-tour-paths

lawrencecchen commented Sep 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

cursor Bot commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

teamleaderleo commented Sep 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

lawrencecchen commented Sep 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Changelog

Summary by cubic

Summary by CodeRabbit

Uh oh!

cursor Bot commented Sep 28, 2026

Bugbot is paused — on-demand spend limit reached

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

coderabbitai Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

teamleaderleo commented Sep 28, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lawrencecchen commented Sep 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading