Skip to content

Add Vietnamese README - #1533

Closed
eliophan wants to merge 3 commits into
manaflow-ai:mainfrom
eliophan:main
Closed

eliophan wants to merge 3 commits into
manaflow-ai:mainfrom
eliophan:main

Conversation

@eliophan

@eliophan eliophan commented Mar 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Add Vietnamese translation of the main README
  • Include Vietnamese in the language list on the main README
  • Align the language selector formatting in the Vietnamese README

Testing

  • Not run (per project policy)

Demo Video

For UI or behavior changes, include a short demo video (GitHub upload, Loom, or other direct link).

  • Video URL or attachment:

Review Trigger (Copy/Paste as PR comment)

@codex review
@coderabbitai review
@greptile-apps review
@cubic-dev-ai review

Checklist

  • I tested the change locally
  • I added or updated tests for behavior changes
  • I updated docs/changelog if needed
  • I requested bot reviews after my latest commit (copy/paste block above or equivalent)
  • All code review bot comments are resolved
  • All human review comments are resolved

@vercel

vercel Bot commented Mar 16, 2026

Copy link
Copy Markdown

@eliophan is attempting to deploy a commit to the Manaflow Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@eliophan

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

To use Codex here, create an environment for this repo.

@eliophan

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Mar 16, 2026

Copy link
Copy Markdown
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@eliophan

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai

coderabbitai Bot commented Mar 16, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Adds a new Vietnamese README and reorders language links in README.md; introduces an AppStorage-backed configurable "Send Feedback" keyboard shortcut and wires it into the app Help menu in Sources/cmuxApp.swift.

Changes

Cohort / File(s) Summary
Language Links
README.md
Inserted a Tiếng Việt link and reordered the language list in the README header.
Documentation Translation
README.vi.md
New Vietnamese translation of the project README (installation, features, shortcuts, nightly/build info, contribution, license).
App Shortcut / Help Menu
Sources/cmuxApp.swift
Adds AppStorage field for persisted "Send Feedback" shortcut, decodes fallback/default shortcut, and registers the shortcut as a Help menu command entry.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 Here’s a hop, a tiny tweak,
New Vietnamese words for all to seek.
A shortcut saved, a menu new,
I nibble bugs and say, “sku!” 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The PR description omits critical information about code changes (Help menu and Send Feedback shortcut) and lacks testing details, but covers the main documentation additions. Update the Summary section to document all changes including Help menu modifications and Send Feedback shortcut implementation. Clarify the testing approach given the 'per project policy' statement.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add Vietnamese README' is concise, specific, and clearly reflects the primary change—adding a Vietnamese translation (README.vi.md) to the repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai

cubic-dev-ai Bot commented Mar 16, 2026

Copy link
Copy Markdown

@cubic-dev-ai review

@eliophan I have started the AI code review. It will take a few minutes to complete.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@eliophan eliophan closed this Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant