Repository navigation
Add a dragAt step to the dogfood tour format - #15315
Conversation
|
Warning Review limit reachedNext included review available in 18 seconds. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Dogfood build of cmux DEV pr-15315-a645df9b.app The link opens this exact commit in the cmux dev menu bar app. The build starts on each push and the page waits until it is ready; a newer push replaces it. It signs in against production, so Cloud or backend changes still need a tagged build with a development backend. Dogfood tours of
|
CI failure attributionCI stopped on
Matched log linesNot re-run automatically: Written by |
|
Automatic catch-up couldn't merge Label |
This comment has been minimized.
This comment has been minimized.
|
Merged main in at One conflict, in the step-kind set: main added CI attribution on the previous headFour red lanes, and none of them are this change. Three are capacity: two runners refused the job outright and one stopped talking to the server mid-job. Tracked in #15350. The fourth was classified as code, but it is a known flake rather than a regression: What is still blockingThe CLA check, and no push can clear it. The bot's count is 1 of 2 committers signed, and the one it cannot resolve is the author Two ways out, per the bot:
The first needs the account owner. I am not doing the second: re-attributing someone else's commit is not my call, and it would mean force-pushing this branch. ReviewReview: read the merged parser end to end rather than just my own hunk. Fixed: the step-kind conflict against main, resolved as a union with both step types kept. Left: the CLA check, which needs the address linked or the commit re-authored by its owner. Nothing else. The step type has no dependents in this PR, and #15349 says plainly that it cannot demonstrate a drag floor until this lands. |
|
recheck |
Tours could click and hover but not drag, so a resizer or any other drag handle could not be exercised from a tour. dragAt presses at one point in the window and drags to another, both in the same 0 to 1 window space the existing clickAt and hoverAt steps use. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
a645df9 to
9befcee
Compare
|
Review record: the earlier review at a208db1 (comment above) stands. The diff has not changed since then: it is still the The CLA check was red because the original commit was authored with an address not linked to any GitHub account. Both the commit and the branch are @teamleaderleo's, so I re-authored the commit to his linked address and rebased it onto current main as a single commit (9befcee). Its tree is identical to merging main into the previous head a645df9. Authorship stays with @teamleaderleo, and the only thing that changed is the address. |
|
Merge receipt for |
04c8747 ci: scope contributor web complexity to web changes (manaflow-ai#15424) 1b3fbff ci: accept dynamic app-host shard names (manaflow-ai#15426) 16f0f97 Fix Cloud graph freezing on daemons that send no cursor (manaflow-ai#15283) eb2331c Add a dragAt step to the dogfood tour format (manaflow-ai#15315) 90e6862 Fix split-space admission after sidebar pane changes (manaflow-ai#15422)





Dogfood tours can click, double-click, right-click and hover, at an element or at a point, but they cannot drag. Anything whose only interaction is a drag is therefore unreachable from a tour: sidebar and pane resizers, the split divider, dragging a tab to another pane or window.
This adds a
dragAtstep:{"dragAt": {"from": {"x": 0.2, "y": 0.5}, "to": {"x": 0.1, "y": 0.5}, "duration": 0.2}}Both points are in the same 0 to 1 window space that
clickAtandhoverAtalready use,durationis the press-and-hold before the drag begins and defaults to 0.2 seconds, and it lowers ontoXCUICoordinate.press(forDuration:thenDragTo:).Why now
Three groups landing UI changes this week are writing coordinate-driven tours, and one of them established that
clickAtreportsokwhether or not anything is under the point. A tour that asserts nothing about what it hit is weak evidence, and the cases people most want frames of are the resize interactions, which could not be driven at all. This is 26 lines of harness and one row of reference documentation, with no product code involved.Provenance
The commit is @teamleaderleo's, written on a sidebar branch where it did not belong, and it is kept at its original authorship here rather than reattributed. It was removed from #14875 and recovered onto this branch so it lands where it is useful to everyone rather than riding along with a sidebar setting. Cherry-picking it onto current main conflicted with #15239, which added
modifiersto every click and hover step after this commit was written; the resolution keeps #15239's modifier handling in full and addsdragAtalongside it.Tests
No new test. The step is exercised by any tour that uses it, and a scenario that names an unknown step already fails loudly through
DogfoodStep.kinds.python3 scripts/verify-local.pypassed the 15 checks it selected for these paths, including Swift syntax and test wiring.Changelog
none
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds a
dragAtstep to the dogfood tour format so tours can reach drag-only interactions like pane resizers and split dividers.fromandtopoints in the same 0 to 1 window spaceclickAtandhoverAtuse, plus an optionaldurationthat defaults to 0.2 seconds.from, then drags totoviaXCUICoordinate.press(forDuration:thenDragTo:).Written for commit 9befcee. Summary will update on new commits.