Repository navigation
localize-changes: read multi-line defaultValue literals - #15275
teamleaderleo wants to merge 1 commit into
Conversation
The defaultValue pattern only matched single-line strings, so a `"""` help text parsed as an empty string: the helper wrote an empty English value into the catalog and the merge then rejected the packet rows. Match multi-line literals, strip the closing delimiter's indentation the way Swift does, and skip them when scanning for the call's closing paren. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Warning Review limit reachedNext included review available in 32 seconds. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Dogfood build of cmux DEV pr-15275-4b6f071a.app The link opens this exact commit in the cmux dev menu bar app. The build starts on each push and the page waits until it is ready; a newer push replaces it. It signs in against production, so Cloud or backend changes still need a tagged build with a development backend. |
|
Superseded by #15265, which landed the same multi-line |
|
Automatic catch-up couldn't merge Label |
scripts/localize-changesmatched only single-linedefaultValuestrings, so a"""help text (the styleCLI/CMUXCLI+Current.swiftuses) parsed as an empty string. The helper then wroteen = ""into the catalog, and the merge rejected every packet row for that key with "completed packet row requires catalog, key, source, and locale strings". Each rerun resetento empty again.defaultValuepattern now also matches"""literals. A newmultiline_swift_bodystrips the closing delimiter's indentation the way Swift does, and still reports line-continuation escapes as needing manual review.swift_call_suffixskips over"""blocks when it looks for the closing paren.Found while localizing #15273.
Testing
python3 tests/test_localize_changes.py: 25 tests pass. The newtest_multiline_default_is_read_whole_and_deindentedfails without the fix.cli.current.helpto exactly its catalogenvalue.🤖 Generated with Claude Code
Summary by cubic
Fixes
scripts/localize-changes.pyto read Swift multi-linedefaultValueliterals. Previously"""help text parsed as an empty string, so the catalog wroteen = ""and the merge rejected every packet row for that key; now the parser strips the closing delimiter's indentation as Swift does and flags\line continuations for manual review. Also makes the closing-paren scan skip over multi-line blocks so the call boundary is found correctly.Written for commit 4b6f071. Summary will update on new commits.