Repository navigation
ci: force relay rollover renewal in release gate - #15212
Merged
Merged
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe simulator launcher forwards ChangesRenewal interval launch configuration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The relay-rollover gate receives the intended early renewal interval, and other scenarios retain their normal schedule. No actionable merge risk remains. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The new timing control is limited to simulator launches, uses a fixed value in the relay-rollover gate, and is bounded by the app. The gate checks a rollover result. No attacker path or security regression was established, but successful operation after the change has not been demonstrated by the supplied validation. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Dogfood build of cmux DEV pr-15212-32b23b3d.app The link opens this exact commit in the cmux dev menu bar app. The build starts on each push and the page waits until it is ready; a newer push replaces it. It signs in against production, so Cloud or backend changes still need a tagged build with a development backend. |
Contributor
|
Merge receipt for |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 28, 2026
1b55596 Move saved sessions between cmux installs: restore-session --from / --export (manaflow-ai#14861) 0e1ab96 ci: force relay rollover renewal in release gate (manaflow-ai#15212) a3d6070 Fix Cloud projection reads mutating observation state (manaflow-ai#15126) 5171e34 docs: say Cloud turns on per Mac through a staged rollout (manaflow-ai#15194) 53395a8 Recover a missing team scope instead of failing Mac pairing (manaflow-ai#15083) 454f191 ci: read the gui backlog eight runs at a time in late placement (manaflow-ai#15207) 147a616 ci: cmux-tui's release-path macOS builds take the owned side lane first (manaflow-ai#15184) c74b646 License the cmux server software under the Business Source License 1.1 (manaflow-ai#15206) 0bb41fa test: restore the first responder before the dictation paste test's Cmd+V (manaflow-ai#15201) b17bc18 ui-tests: empty Diagnostics Reporter's queue before closing it (manaflow-ai#15189) d5f71c5 ci: iOS picker charges runs by their live jobs, not their titles (manaflow-ai#15188) 3c2cb96 Pane focus memory and New Pane (Auto Layout) (manaflow-ai#15125) 89519d8 ci: expand an empty E2E -only-testing list under bash 3.2 (manaflow-ai#15208) f225777 Ghostty config live reload: keep saves during a reload, reload a theme preview once, watch XDG_CONFIG_HOME (manaflow-ai#15191) 714ec53 ci: stop at a full disk on clonefile, and never nest a seed clone (manaflow-ai#15199) 48d662a ci: ui-tests dispatches UI tests with main's dispatcher (manaflow-ai#15193) 3412812 Restore the Cloud template terminal in place after a daemon restart (manaflow-ai#15200) # Conflicts: # .github/workflows/ci-macos.yml # .github/workflows/ci.yml # .github/workflows/cmux-tui-build-package.yml # .github/workflows/cmux-tui.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The relay-only release gate runs a 330-second rollover probe, but its debug renewal interval was never forwarded to the simulator. Both staging and production therefore completed the one-hour soak and then failed before credential rollover.
The gate now requests renewal after 180 seconds for the relay-rollover scenario, and the mobile simulator launcher forwards that value into the app. Normal app launches do not set the variable and keep their production renewal schedule.
Validation
bash -n scripts/run-iroh-release-gate.sh scripts/mobile-dev-launch.shgit diff --checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes the relay-only release gate so credential rollover completes after the soak instead of failing.
The gate previously completed the one-hour soak without forwarding the debug renewal interval to the simulator, so staging and production then failed before credential rollover. The gate now requests renewal after 180 seconds for the relay-rollover scenario, and the mobile simulator launcher forwards that value. Normal launches leave it unset and keep the production renewal schedule.
Written for commit 32b23b3. Summary will update on new commits.
Summary by CodeRabbit