Repository navigation
Match the CMUX_NO_GIT_WATCH contract to bash without a PR poller - #15099
Conversation
#15074 pinned bash to stopping _CMUX_PR_POLL_PID and deleting the per-panel PR cache files at the opt-out prompt. #15075, merged minutes later, removed bash's PR poller and deliberately leaves old cache files alone, so tests/test_shell_no_git_watch.py fails with Apple bash 3.2 on main. The PR-poll and cache checks now run for zsh only, which still has both; bash is still held to stopping its tracked Git job and every other opt-out behavior. docs/shell-integration.md says the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reachedNext included review available in 27 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Merge receipt for |
10505af fix(cloud): recover machine list on app foreground (manaflow-ai#15100) (manaflow-ai#15104) 22835e8 Docs: raise search field contrast (manaflow-ai#14365) 18abc85 Report a non-running terminal as surface_unavailable in read_text (manaflow-ai#15101) b23420c Document and tool in-place cmux-tui upgrades for running Cloud machines (manaflow-ai#15122) f1c54d0 ci: charge newer runs one root runner each when gui runners are on (manaflow-ai#15124) b7ce8d0 Bound the Iroh release-gate launcher 3606617 Stop CLI Sentry floods from caller state and unattributed journal failures (manaflow-ai#15103) 446581e ci: send owned gui jobs past a round of the gui queue to Blacksmith (manaflow-ai#15115) 507890c ci: refit the warm-distance model on 741 owned admissions (manaflow-ai#15117) 5bee212 Match the CMUX_NO_GIT_WATCH contract to bash without a PR poller (manaflow-ai#15099) # Conflicts: # .github/workflows/ci-macos.yml
tests/test_shell_no_git_watch.pyfails onmainwith Apple's/bin/bash3.2. The two PRs involved conflict:_CMUX_PR_POLL_PIDand delete/tmp/cmux-pr-cache-<panel>.*at the opt-out prompt.Neither PR's CI ran the test against the other's change. The macOS shell lane now fails on any PR whose app-host shard 4/7 gets that far, for example #12809 (run 36368050143, job 108761357376).
The bash subtests now check what bash still does:
The PR-poll PID and cache-file checks now run for zsh only, since zsh still has both.
docs/shell-integration.mdnow says the same. No shell integration code changes.Changelog
none
Validation
origin/mainat2aa892bd86, bash 3.2.57:python3 tests/test_shell_no_git_watch.pyfails the bash subtests oftest_disabled_prompt_command_and_head_change(sixCACHE_REMAINS) andtest_next_prompt_stops_tracked_jobs. In the second, the_CMUX_PR_POLL_PIDprocess outlives the prompt; the_CMUX_GIT_JOB_PIDprocess is stopped.726468cbf9and again on4aa4b8bfdd, a one-word doc fix: the same command passes all 5 tests._cmux_pr_cache_cleara no-op fails the zsh subtest.killfails the bash subtest oftest_next_prompt_stops_tracked_jobs.python3 scripts/verify-local.py: 14 of 15 checks passed.swift-syntaxwas skipped because the change has no Swift files.macosworkflow for this test-and-docs diff, so the macOS shell lane didn't run this test on this branch. The local run above is the evidence. It stays in themacos-shelllane because it needs Apple's/bin/bash3.2 and/bin/zsh.docs/shell-integration.mdis English-only, with no web or locale copies. No catalog strings changed.🤖 Generated with Claude Code