Repository navigation
ci: count an unwritable Homebrew prefix as a machine failure - #15070
Merged
Merged
Conversation
A runner whose /opt/homebrew is not owned by the runner user fails
before any test starts ("The following directories are not writable by
your user"), as run 36356259693 did. The code cannot cause it, so the
focused dispatcher and the bisect treat it as a machine failure.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Merge receipt for |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 27, 2026
0485e93 ci: count an unwritable Homebrew prefix as a machine failure (manaflow-ai#15070) 8ce15d4 Show Cloud machine-list recovery instead of a stale 'unreachable' on return (manaflow-ai#14777) 51aad0b test: keep remote OpenCode fixture paths consistent (manaflow-ai#15062) 83270f1 test: bound remaining yield-count polls by deadlines (manaflow-ai#14488)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A macOS runner whose
/opt/homebrewis not owned by the runner user fails in the test step's Homebrew install, before any test starts: "The following directories are not writable by your user". Run 36356259693 hit it on one owned Mac. The code under test cannot cause this, soscripts/ci/machine_failure.pynow lists it with the other runner-level signatures. The focused dispatcher then retries it automatically, and the regression bisect counts it as an error, not a failing commit.The Mac itself still needs its Homebrew prefix fixed (
chown -Rto the runner user). This change only stops the error from being read as a test result.Testing
tests/test_ci_machine_failure.pyadds a case for the Homebrew message. All cases pass locally.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Counts a macOS runner whose Homebrew prefix isn't writable by the runner user as a machine failure instead of a product failure, so the focused dispatcher retries it and the regression bisect no longer blames a commit. Adds a test case for the Homebrew error message.
Written for commit 04aad34. Summary will update on new commits.
Summary by CodeRabbit