Repository navigation
tools: wire-app-sources finds --dir among the top-level groups - #15059
Merged
Merged
Conversation
Take the directory's group from the project's top-level groups, so a nested group with the same path cannot be picked, and reject nested or missing --dir values. Tests cover another top-level directory, the namesake case and the errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Merge receipt for |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 27, 2026
c5024fa tools: wire-app-sources finds --dir among the main group's children (manaflow-ai#15059) 2207bc8 tools: wire-app-sources wires any target; guard cmuxUITests wiring (manaflow-ai#15057) dc56eb7 ci: swift-package-tests through one lane script, opt-in build-fleet step (hq#794) (manaflow-ai#15042) bee385d Add an Accent Color setting and use one accent for cmux chrome (manaflow-ai#14988) # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #15057 from its review.
wire-app-sources.pylooked up the--dirgroup by the first group whosepathmatched, so a nested group with the same path (say aSettingsgroup inside another folder) could be picked and every file resolved against the wrong directory. It now takes the group from the project's main group's children, and rejects a nested (Sources/Foo) or missing--dirwith a clear error. No directory the guard uses today was affected.Testing
tests/test_wire_app_sources.py(13 cases) adds a fixture with a nested group also namedSources, listed before the real one; the old lookup picks the nested group and fails this case. It also covers wiring a file into another top-level directory, and the nested and missing--direrrors.--checkpasses forcmux/Sources,cmuxUITests/cmuxUITestsandcmuxTests/cmuxCLITestSupport.Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes
wire-app-sources.pyresolving--diragainst a nested group with the same path, so files get wired into the correct top-level directory.--diramong the project's main group's children.--dirvalues with a clear error.Written for commit b4647be. Summary will update on new commits.
Summary by CodeRabbit