Repository navigation
cmux import: write through the shared Ghostty config writers - #15055
Merged
Merged
Conversation
An imported font now replaces the user's font list: font-family is written
as a reset ("") followed by the family through
CmuxGhosttyConfigSettingEditor.updatedContents(_:setting:values:), the same
multi-value writer the Settings font row uses. The previous one-line-per-key
rewrite would have dropped that reset and left the imported font as a
fallback after the user's fonts.
GhosttyConfigPatcher becomes GhosttyConfigDiffer, which only builds the
before/after listing (still CRLF-safe); every config write goes through the
shared editor, and the theme is selected through CmuxManagedThemeConfigFile.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 32 seconds. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
|
Merge receipt for |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 27, 2026
2fbaf0a ci: keep one root per multi-root mini at main; park pull request builds there (manaflow-ai#15056) 35b642c Add Don't ask again to close confirmation dialogs (manaflow-ai#15052) cc4e8cf cmux import: write through the shared Ghostty config writers (manaflow-ai#15055) a8ee58c Add base keymap presets for keyboard shortcuts (manaflow-ai#15003) fc39e4c Embed cmux.json schema as a raw string so schema PRs merge (manaflow-ai#15048) 32d9435 Drive the cmux sidebar from Claude Code on SSH relay hosts (manaflow-ai#14974) # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmux import(#15004) wrotefont-familyas a single line, replacing every earlier assignment. With the Settings font row from #15005, cmux's config can hold afont-family = ""reset followed by the chosen family; the import's one-line rewrite would drop that reset, so the imported font became a fallback after the user's other fonts instead of replacing them.Now the import writes through the same shared writers as Settings and
cmux themes:CmuxGhosttyConfigSettingEditor.updatedContents(_:setting:values:)(viawriteSetting(key:values:)).font-familyis written as""then the family, the same shape the Settings font row writes, so the imported font replaces the list.CmuxManagedThemeConfigFile, and the "old theme" shown in the diff is read from its managed block.GhosttyConfigPatcheris nowGhosttyConfigDiffer: it only builds the before/after listing the CLI prints (CRLF files still read without a stray\r). Keys already set to the imported values are skipped. New keys are appended by the shared writer, without the old# Imported from ...comment.--jsonchanges[].newis now a list of values, sincefont-familywrites two lines.Verification
swiftc -typecheckof the CmuxTerminalImport package sources: clean.Changelog
Fixed: an imported font now replaces your font list instead of becoming a fallback
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Makes
cmux importwrite through the same shared config writers as Settings andcmux themes, so an imported font replaces your font list instead of becoming a fallback.Previously the import rewrote
font-familyas a single line, dropping thefont-family = ""reset that now precedes the chosen family. Now:CmuxGhosttyConfigSettingEditor'swriteSetting(key:values:);font-familyis written as""then the family.CmuxManagedThemeConfigFile.GhosttyConfigPatcherbecomesGhosttyConfigDiffer, which only builds the before/after listing the CLI prints; CRLF files are still read without a stray\r.--jsonchanges[].newis now a list of values, sincefont-familywrites two lines.Written for commit d57eaeb. Summary will update on new commits.