Skip to content

ui-tests: wait for static preflight when a reused compile skips the gate - #15051

Merged
teamleaderleo merged 1 commit into
mainfrom
ui-tests-static-preflight
Sep 27, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
ui-tests-static-preflight

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #14964's review.

ui-tests waits for the macOS admission gate, which needs static preflight. A run that reuses an earlier compile skips the gate, though, and #14964 lets ui-tests run in that case. So a pull request whose static preflight had failed could still spend an owned Mac on its UI classes. ui-tests now needs static-preflight directly and requires it to pass.

The admission-gate derivation guard (test_macos_admission_gate_needs_every_fast_linux_only_job) and test_merge_groups_stop_at_the_first_failure pass locally; CI runs the rest.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Makes ui-tests require static-preflight to pass directly, so it can no longer dispatch a UI run for a pull request whose static preflight already failed. The admission gate needs static preflight, but a run that reuses an earlier compile skips the gate, leaving ui-tests as the only path that could spend an owned Mac without preflight having passed.

Written for commit 3d31c87. Summary will update on new commits.

Review in cubic

The admission gate needs static preflight, but a run that reuses an
earlier compile skips the gate, so ui-tests could dispatch a UI run for
a pull request that static preflight had already failed. ui-tests now
needs static preflight directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 10 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 620a85bc-c606-441d-8c1e-644b53be2c81

📥 Commits

Reviewing files that changed from the base of the PR and between 36ee3e9 and 3d31c87.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

— Toolbox g1 🔔 Reviewed the CI dependency fix. All required checks pass, and the change prevents UI jobs from bypassing a failed static preflight when compile output is reused. Enabling squash auto-merge.

@teamleaderleo
teamleaderleo merged commit 7f97b0d into main Sep 27, 2026
44 checks passed
@teamleaderleo
teamleaderleo deleted the ui-tests-static-preflight branch September 27, 2026 18:58
@github-actions

Copy link
Copy Markdown
Contributor

Merge receipt for 3d31c87169: every check was green at merge (12 verified; 12 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 27, 2026
a64d59b tools: ui-lab renders view code in seconds; wire-app-sources.py (manaflow-ai#15049)
4e03ed2 fix(events): harden durable replay recovery (manaflow-ai#15054)
ac51546 Settings: native terminal theme gallery (manaflow-ai#14996)
867e7a0 Add native Ghostty option rows to Settings > Terminal (manaflow-ai#15005)
7f97b0d ui-tests: wait for static preflight when a reused compile skips the gate (manaflow-ai#15051)
c708e0c Add a chat view for the terminal's agent session (Claude Code, Codex) (manaflow-ai#14965)
b762a3d ci: the picker fetches kept bases' trees, not just checks their commits (manaflow-ai#15053)
2570eed docs: refresh and trim contributor build guidance (manaflow-ai#15050)
20019d3 ci: re-run by cause: host faults to Blacksmith, code failures back to the minis (manaflow-ai#15045)
36ee3e9 Add Warn Before Closing Workspace setting (manaflow-ai#14979)
4df2317 CI: run changed UI test classes in PRs, keep UI runs off Blacksmith, probe the GUI session (manaflow-ai#14964)
9efe05e Owned-pool sweeper: page the marker listing back to the runs it adopts (manaflow-ai#15033)
6361554 fix(events): restore durable replay across restarts (manaflow-ai#15030)
0bc5145 ci: place side lanes on the light minis one per idle side runner (manaflow-ai#15047)
9d4e92b ci: the E2E rule's queue-round reason names the owned pools the run may take (manaflow-ai#15044)
9e6e216 Dogfood the app from CI with JSON tours (manaflow-ai#14928)
fd3dcf6 ci: retry the picker's kept-base fetch and record how it went (manaflow-ai#15040)
3a64e0e Reload the Ghostty config when its files change, and show config errors (manaflow-ai#14859)
f412b05 test: hit-test the browser portal tab strip with its own click (manaflow-ai#15031)
64d5235 test: route the reopen-last-closed shortcut through the test's own window (manaflow-ai#15036)
7037079 ci: take the gui token in the E2E test job's step, not at job start (manaflow-ai#15037)

# Conflicts:
#	.github/workflows/ci-macos.yml
#	.github/workflows/ci.yml
#	.github/workflows/remote-daemon.yml
#	.github/workflows/test-e2e.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant