Skip to content

docs: load the deep review protocol only when needed - #15007

Merged
teamleaderleo merged 1 commit into
mainfrom
docs/review-skill-progressive-disclosure
Sep 27, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
docs/review-skill-progressive-disclosure

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 27, 2026 •

Copy link
Copy Markdown
Collaborator

The review skill loads a 16.9 KB adversarial protocol for routine pre-merge reviews. Keep the ordinary subagent pass in a 2.7 KB entry point and load detailed discovery, verification, receipts and dogfood procedures only when that workflow needs them.

The advanced protocol and merge policy remain intact. Its source/policy snapshot requirements are explicitly read before discovery or repair, and existing links to SKILL.md#dogfood-and-merge keep working. Every new Markdown reference stays under 6 KB; the entry point stays under 3,600 bytes and 500 words.

Validation: skill-creator quick validation, scoped scripts/verify-local.py, git diff --check, and local link/anchor checks passed. An independent subagent reviewed semantic preservation and simulated routine versus high-risk review routing; its source-capture ordering finding was fixed and rechecked. Docs only; no app build.

Changelog

none


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Restructures the cmux-review skill so the full adversarial protocol loads only when a deep review is needed, keeping routine pre-merge reviews on a small entry point. No behavior change to the review process — only how its instructions are loaded.

  • Moves dogfood/merge, discovery, verification, and receipt/report procedures into four reference files under skills/cmux-review/references/.
  • Cuts SKILL.md from ~16.9 KB to under 3,600 bytes and 500 words; every new reference stays under 6 KB.
  • Existing SKILL.md#dogfood-and-merge anchors keep working; the advanced protocol and merge policy are unchanged.
  • Docs-only change; no app build.

Written for commit fb8cc64. Summary will update on new commits.

Review in cubic

@cursor

cursor Bot commented Sep 27, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 803f15f9-d209-4268-91a1-6184d4e2bf29

📥 Commits

Reviewing files that changed from the base of the PR and between 1921636 and fb8cc64.

📒 Files selected for processing (5)
  • skills/cmux-review/SKILL.md
  • skills/cmux-review/references/dogfood-and-merge.md
  • skills/cmux-review/references/review-discovery.md
  • skills/cmux-review/references/review-receipts.md
  • skills/cmux-review/references/review-verification.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo
teamleaderleo merged commit c9a6a0e into main Sep 27, 2026
53 of 54 checks passed
@teamleaderleo
teamleaderleo deleted the docs/review-skill-progressive-disclosure branch September 27, 2026 13:33
@github-actions

Copy link
Copy Markdown
Contributor

Merge receipt for fb8cc647a2: every check was green at merge (10 verified; 11 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 27, 2026
82c26b3 ci: take the gui token in the app-host shard's restore, not at job start (manaflow-ai#15012)
3761671 iOS: fix stale team nightly floor expectation in What's New copy test (manaflow-ai#14917)
5e19a98 docs: focus custom sidebar tabs by surfaceId in the actions example (manaflow-ai#15002)
294ee6e sidebar: Strip inline Markdown from notification previews (manaflow-ai#12030)
ceb3030 Keep detached workspace process titles updateable (manaflow-ai#4947)
8be7364 test: kill hosted test shells before freeing their terminals (manaflow-ai#14957)
da291df cmux-tui: do not query the host terminal when the reply cannot be read (manaflow-ai#12419)
98767c8 ci: keep earlier reviewed CLA policies valid for branches behind main (manaflow-ai#15008)
7167b77 feat(custom-sidebars): fixedSize and reactive frame specs for JS sidebars (manaflow-ai#14845)
716bbb5 Fix notification hook descriptor inheritance (manaflow-ai#11649)
03b191d cmux-tui: pass the zig target on a native windows-gnu host (manaflow-ai#12416)
c9a6a0e docs: load the deep review protocol only when needed (manaflow-ai#15007)
e5af879 Match pane indicator strokes and the file path header to shared chrome metrics (manaflow-ai#14982)
0def9e1 Show one fixed subtitle for each Settings row and fix localized labels (manaflow-ai#14883)
1921636 ci: route picker-less macOS lanes to the owned minis for trusted events (manaflow-ai#14794)

# Conflicts:
#	.github/workflows/app-host-test-rerun.yml
#	.github/workflows/auth-refresh-tests.yml
#	.github/workflows/ci-health-report.yml
#	.github/workflows/ci-macos.yml
#	.github/workflows/ci-owned-pool-rescue.yml
#	.github/workflows/ci-repo-variables.yml
#	.github/workflows/cloud-command-deadlines.yml
#	.github/workflows/cloud-machine-tests.yml
#	.github/workflows/cloud-task-local-tests.yml
#	.github/workflows/cmux-tui.yml
#	.github/workflows/iroh-v2.yml
#	.github/workflows/relay-tls.yml
#	.github/workflows/reload-build.yml
#	.github/workflows/remote-daemon.yml
#	.github/workflows/resolve-dispatch-ref.yml
#	.github/workflows/terminal-hang-diagnostics.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant