Add Warn Before Closing Workspace setting

CHANGELOG.md

@@ -68,6 +68,7 @@ All notable changes to cmux are documented here.
 - iOS (beta): Settings > About has a Support Information action that copies your account, install, and device IDs plus app version for support requests ([#13448](https://github.com/manaflow-ai/cmux/pull/13448)) -- thanks @azooz2003-bit!
 - iOS (beta): Version 1.0.6 shows a one-time notice with the minimum Mac versions it needs, then opens the Mac pairing guide ([#14112](https://github.com/manaflow-ai/cmux/pull/14112)) -- thanks @azooz2003-bit!
 - iOS (beta): Settings > Reset > Erase All Data on This Device signs out and returns the app to a fresh-install state ([#14140](https://github.com/manaflow-ai/cmux/pull/14140))
+- Settings > App > Warn Before Closing Workspace (`app.warnBeforeClosingWorkspace`, on by default) turns off the "Close workspace?" prompts; pinned workspaces still ask ([#14979](https://github.com/manaflow-ai/cmux/pull/14979))
 
 ### Changed
 - Each Settings toggle and picker row shows one fixed subtitle instead of text that changes with the selected value, and localized Settings titles and Feed, Dock, and Cloud Machines labels use corrected wording ([#14883](https://github.com/manaflow-ai/cmux/pull/14883)) -- thanks @agoodkind!

Packages/macOS/CmuxSettings/Sources/CmuxSettings/Keys/AppCatalogSection.swift

@@ -182,6 +182,29 @@ public struct AppCatalogSection: SettingCatalogSection {
         )
     )
 
+    /// Gates the "Close workspace?" prompts (running processes, multi-workspace
+    /// close). The "Close pinned workspace?" prompt is not gated by it.
+    public let warnBeforeClosingWorkspace = DefaultsKey<Bool>(
+        id: "app.warnBeforeClosingWorkspace",
+        defaultValue: true,
+        userDefaultsKey: "warnBeforeClosingWorkspace",
+        userFacing: UserFacingSettingDescriptor(
+            title: String(
+                localized: "settings.app.warnBeforeClosingWorkspace",
+                defaultValue: "Warn Before Closing Workspace"
+            ),
+            section: .app,
+            searchID: "warn-before-closing-workspace",
+            searchKeywords: ["close", "workspace", "confirmation", "command-shift-w", "cmd-shift-w", "agent", "running"],
+            control: .toggle(.init(
+                commandPalette: .init(
+                    id: "warnBeforeClosingWorkspace",
+                    keywords: ["warn", "close", "workspace", "confirmation", "cmd-shift-w"]
+                )
+            ))
+        )
+    )
+
     public let warnBeforeClosingTabXButton = DefaultsKey<Bool>(
         id: "app.warnBeforeClosingTabXButton",
         defaultValue: false,

Packages/macOS/CmuxSettings/Tests/CmuxSettingsTests/DomainSettingsStoreTests.swift

@@ -27,6 +27,16 @@ struct DefaultsKeyDirectAccessTests {
         #expect(key.value(in: defaults) == true)
     }
 
+    @Test func warnBeforeClosingWorkspaceDefaultsToEnabled() {
+        let defaults = makeScratchDefaults()
+        let key = AppCatalogSection().warnBeforeClosingWorkspace
+        #expect(key.id == "app.warnBeforeClosingWorkspace")
+        #expect(key.value(in: defaults) == true)
+
+        defaults.set(false, forKey: "warnBeforeClosingWorkspace")
+        #expect(key.value(in: defaults) == false)
+    }
+
     @Test func undecodableStoredValueReadsAsDefault() {
         let defaults = makeScratchDefaults()
         let key = AppCatalogSection().confirmQuitMode

Packages/macOS/CmuxSettings/Tests/CmuxSettingsTests/UserFacingSettingDescriptorTests.swift

@@ -8,6 +8,7 @@ struct UserFacingSettingDescriptorTests {
         let catalog = SettingCatalog()
         let keys = [
             catalog.app.warnBeforeClosingTab,
+            catalog.app.warnBeforeClosingWorkspace,
             catalog.app.hideTabCloseButton,
             catalog.app.renameSelectsExistingName,
         ]

Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Navigation/CuratedSettingEntry+Default.swift

@@ -93,6 +93,7 @@ extension Array where Element == CuratedSettingEntry {
             .init(section: .app, id: "warn-before-quit", title: String(localized: "settings.app.warnBeforeQuit", defaultValue: "Warn Before Quit"), synonyms: "Warn Before Quit app.confirmQuit quit confirmation command-q cmd-q exit close app"),
             .init(userFacing: catalog.app.warnBeforeClosingTab),
             .init(section: .app, id: "warn-before-closing-tab-x-button", title: String(localized: "settings.app.warnBeforeClosingTabXButton", defaultValue: "Warn Before Tab Close Button"), synonyms: "Warn Before Tab Close Button app.warnBeforeClosingTabXButton x button close tab confirmation terminal surface"),
+            .init(userFacing: catalog.app.warnBeforeClosingWorkspace),
             .init(userFacing: catalog.app.hideTabCloseButton),
             .init(userFacing: catalog.app.renameSelectsExistingName),
             .init(section: .app, id: "palette-search-all", title: String(localized: "settings.app.commandPaletteSearchAllSurfaces", defaultValue: "Command Palette Searches All Surfaces"), synonyms: "Command Palette Searches All Surfaces app.commandPaletteSearchesAllSurfaces command palette search all surfaces cmd-p terminal browser markdown"),

Packages/macOS/CmuxSettingsUI/Sources/CmuxSettingsUI/Sections/AppSection.swift

@@ -69,6 +69,7 @@ public struct AppSection: View {
     @State private var confirmQuit: DefaultsValueModel<ConfirmQuitMode>
     @State private var warnCloseTab: DefaultsValueModel<Bool>
     @State private var warnCloseX: DefaultsValueModel<Bool>
+    @State private var warnCloseWorkspace: DefaultsValueModel<Bool>
     @State private var hideCloseButton: DefaultsValueModel<Bool>
     @State private var renameSelects: DefaultsValueModel<Bool>
     @State private var paletteAllSurfaces: DefaultsValueModel<Bool>
@@ -138,6 +139,7 @@ public struct AppSection: View {
         _confirmQuit = State(initialValue: DefaultsValueModel(store: defaultsStore, key: catalog.app.confirmQuitMode))
         _warnCloseTab = State(initialValue: DefaultsValueModel(store: defaultsStore, key: catalog.app.warnBeforeClosingTab))
         _warnCloseX = State(initialValue: DefaultsValueModel(store: defaultsStore, key: catalog.app.warnBeforeClosingTabXButton))
+        _warnCloseWorkspace = State(initialValue: DefaultsValueModel(store: defaultsStore, key: catalog.app.warnBeforeClosingWorkspace))
         _hideCloseButton = State(initialValue: DefaultsValueModel(store: defaultsStore, key: catalog.app.hideTabCloseButton))
         _renameSelects = State(initialValue: DefaultsValueModel(store: defaultsStore, key: catalog.app.renameSelectsExistingName))
         _paletteAllSurfaces = State(initialValue: DefaultsValueModel(store: defaultsStore, key: catalog.app.commandPaletteSearchesAllSurfaces))
@@ -163,7 +165,7 @@ public struct AppSection: View {
             AppChannelSwitchCard(hostActions: hostActions)
         }
         .task {
-            startSettingsObservation([language, appearance, appIcon, placement, inheritDir, minimalMode, keepWorkspaceOpen, firstClick, focusHistoryIncludesPanesAndTabs, equalizeSplitsOnCreate, fileDrop, preferredEditor, openSupported, openMarkdown, globalFontMagnification, markdownFontSize, markdownFontFamily, markdownMaxWidth, canvasPaneGap, canvasSnapping, fileEditorWordWrap, fileEditorSyntaxHighlighting, fileEditorLineNumbers, fileEditorIndentGuides, fileEditorCurrentLineHighlight, fileEditorTabWidth, iMessage, reorder, dockBadge, menuBarOnly, showInMenuBar, paneRing, paneFlash, desktopNotifications, agentPermissionPrompt, agentTurnComplete, agentIdleReminder, soundName, soundCommand, customSoundFile, soundOverrides, telemetry, confirmQuit, warnCloseTab, warnCloseX, hideCloseButton, renameSelects, paletteAllSurfaces])
+            startSettingsObservation([language, appearance, appIcon, placement, inheritDir, minimalMode, keepWorkspaceOpen, firstClick, focusHistoryIncludesPanesAndTabs, equalizeSplitsOnCreate, fileDrop, preferredEditor, openSupported, openMarkdown, globalFontMagnification, markdownFontSize, markdownFontFamily, markdownMaxWidth, canvasPaneGap, canvasSnapping, fileEditorWordWrap, fileEditorSyntaxHighlighting, fileEditorLineNumbers, fileEditorIndentGuides, fileEditorCurrentLineHighlight, fileEditorTabWidth, iMessage, reorder, dockBadge, menuBarOnly, showInMenuBar, paneRing, paneFlash, desktopNotifications, agentPermissionPrompt, agentTurnComplete, agentIdleReminder, soundName, soundCommand, customSoundFile, soundOverrides, telemetry, confirmQuit, warnCloseTab, warnCloseX, warnCloseWorkspace, hideCloseButton, renameSelects, paletteAllSurfaces])
             await soundAgentCache.loadIfNeeded { await hostActions.notificationSoundAgentOptions() }
             if languageAtAppear == nil { languageAtAppear = language.current }; if telemetryAtAppear == nil { telemetryAtAppear = telemetry.current }
         }
@@ -872,6 +874,20 @@ public struct AppSection: View {
             }
             SettingsCardDivider()
 
+            // Warn Before Closing Workspace
+            SettingsCardRow(
+                configurationReview: .json(catalog.app.warnBeforeClosingWorkspace.id),
+                catalog.app.warnBeforeClosingWorkspace.userFacing!.title,
+                subtitle: warnCloseWorkspace.current
+                    ? String(localized: "settings.app.warnBeforeClosingWorkspace.subtitleOn", defaultValue: "Show a confirmation before closing a workspace with a running process, or several workspaces at once.")
+                    : String(localized: "settings.app.warnBeforeClosingWorkspace.subtitleOff", defaultValue: "Workspaces close immediately without confirmation. Pinned workspaces still ask.")
+            ) {
+                Toggle("", isOn: Binding(get: { warnCloseWorkspace.current }, set: { warnCloseWorkspace.set($0) }))
+                    .labelsHidden()
+                    .controlSize(.small)
+            }
+            SettingsCardDivider()
+
             // Hide Tab Close Button
             SettingsCardRow(
                 configurationReview: .json(catalog.app.hideTabCloseButton.id),

Packages/macOS/CmuxSettingsUI/Tests/CmuxSettingsUITests/SettingsRowAnchorResolutionTests.swift

@@ -57,6 +57,7 @@ struct SettingsRowAnchorResolutionTests {
         "app.sendAnonymousTelemetry",
         "app.warnBeforeClosingTab",
         "app.warnBeforeClosingTabXButton",
+        "app.warnBeforeClosingWorkspace",
         "app.workspaceInheritWorkingDirectory",
         "automation.claudeBinaryPath",
         "automation.claudeCodeIntegration",

Packages/macOS/CmuxSettingsUI/Tests/CmuxSettingsUITests/SettingsSearchIndexTests.swift

@@ -61,6 +61,7 @@ struct SettingsSearchIndexTests {
         let index = SettingsSearchIndex(catalog: catalog)
         let keys = [
             catalog.app.warnBeforeClosingTab,
+            catalog.app.warnBeforeClosingWorkspace,
             catalog.app.hideTabCloseButton,
             catalog.app.renameSelectsExistingName,
         ]