Repository navigation
test(cloud): bind the first workspace receipt before discovery - #14618
Conversation
firstWorkspaceReceiptAdoptsPlaceholder bound a create receipt named workspace-1 while the fixture's current snapshot already named workspace a "Same workspace". bindCloudWorkspace then reconciles against that current snapshot, which is newer than the receipt, so the title is "Same workspace" and the test failed on every run since #14459. Clear the snapshot first so the test models the case it names: the receipt arrives before discovery. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe first-receipt test clears Cloud state before binding. Its comments clarify snapshot precedence and identify a separate test for an already-discovered workspace. ChangesCloud workspace naming tests
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~4 minutes Change: Other Merge Risk: ⚪ Minimal · up to No product behavior changes in this PR. The updated test isolates the receipt-before-discovery scenario and checks the expected workspace name; no actionable merge risk is identified. 🚥 Pre-merge checks | ✅ 23 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (23 passed)
Full details: Description checkExplanation The description clearly explains the failing test, the cause, the intended behavior, and the correction. However, it does not include the required Testing section with executed test commands and results, and it does not include the applicable checklist status. Resolution Add a Testing section that names the tests or CI lane executed, states what passed, and identifies any remaining verification. Add the relevant checklist items with their current status, or remove non-applicable items as allowed by the template. ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…pace-receipt-test
|
Merge receipt for |
74b3778 test: restore manaflow-ai#14406's sidebar AX walk assertion lost in the manaflow-ai#14408 squash (manaflow-ai#14593) 3b14475 ci: run swift-package-tests on owned minis when the run builds no Release helper (manaflow-ai#14411) 2a40caa Handle WebAuthn assertions without user handles (manaflow-ai#9060) 6cdb469 Match upload rules on HostName when a broker rewrites the host (manaflow-ai#11477) 265bef2 fix: hide browser affordances while the browser is disabled (manaflow-ai#10866) (manaflow-ai#13023) 99c4404 ci: ignore a GitHub API error in the stale-run check (manaflow-ai#14603) ceae537 test(cloud): bind the first workspace receipt before discovery (manaflow-ai#14618) # Conflicts: # .github/workflows/ci-macos.yml # .github/workflows/ci.yml # .github/workflows/remote-daemon.yml
1 participant
CloudInitialWorkspaceNamingTests/firstWorkspaceReceiptAdoptsPlaceholderfails on main since #14459 (which merged with its ownci-statusred). It failed on app-host shard 3 of #13981:fixture.workspace.title → "Same workspace"where"workspace-1"was expected.The fixture starts with a current daemon snapshot that already names workspace
a"Same workspace".bindCloudWorkspaceadopts the receipt nameworkspace-1, then reconciles against that current snapshot, which is newer than the receipt, so the snapshot name wins. That is the intended product behavior (a rename after create must not be undone by the create receipt), andbindingReconcilesAlreadyDiscoveredNamecovers it.The test now clears the snapshot before binding, so it models the case its name describes: the create receipt arrives before discovery.
discoveryReconcilesAlreadyBoundWorkspaceuses the same setup. No product change.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes the failing
firstWorkspaceReceiptAdoptsPlaceholdertest by clearing the daemon snapshot before binding the workspace receipt.discoveryReconcilesAlreadyBoundWorkspace. No product change.Written for commit 8d2a81d. Summary will update on new commits.
Summary by CodeRabbit