Repository navigation
fix(accessibility): expose focused terminal text area - #14587
austinywang wants to merge 16 commits into
Conversation
…ielement-returns-the-window
…ielement-returns-the-window
…ielement-returns-the-window
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review limit reachedNext included review available in 7 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
…ielement-returns-the-window
…ielement-returns-the-window
…ielement-returns-the-window
…ielement-returns-the-window
…ielement-returns-the-window
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
…ielement-returns-the-window
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
…ielement-returns-the-window
…ielement-returns-the-window
…ielement-returns-the-window
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
…ielement-returns-the-window
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Review notes:
|
Closes #9563
When a terminal pane owns keyboard focus, cmux now reports its text area as
AXFocusedUIElementand exposes the rendered screen throughAXValue, character-range, and attributed-text APIs. Focus changes notify both the window and application accessibility clients, so selection readers can follow pane switches.Regression coverage first reproduces empty terminal AX content and window-level focus, followed by the fix. Local validation passed Swift syntax parsing, localization parity across all nine macOS locales, package policy, and diff checks. Native tests and builds require the tagged fleet workflow.
— SableLoom9563 pending (run: run_issue9563_14d2618fe095; session: 01a0d838-5a14-7a41-a0be-040700eacaf5)
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Makes
AXFocusedUIElementresolve to the focused terminal view so macOS AX clients can read the rendered screen when a terminal pane has keyboard focus instead of stopping at the window element. Closes #9563.AXFocusedUIElementreturns the terminal view when it owns keyboard focus; previously it returned the window.AXValue, character-range, line, and attributed-text APIs now expose the rendered screen;AXValuepreviously returned only selected text or an empty string..focusedUIElementChangednotifications to both the window and the app so selection readers can follow pane switches.Written for commit 1ff69fa. Summary will update on new commits.
Summary by CodeRabbit