Fix main CI regressions

[lawrencecchen]

Summary

• call textInputClientDidUpdateSelection dynamically so the macOS 14 compatibility lane still builds with Xcode 16.2
• replace stale release-app-support tests with file-backed coverage for GhosttyApp.cmuxAppSupportConfigURLs

Testing

• ./scripts/download-prebuilt-ghosttykit.sh
• ./scripts/reload.sh --tag task-fix-main-cicd (build succeeded)

Issues

• Related: https://github.com/manaflow-ai/cmux/actions/runs/23086348082
• Related: https://github.com/manaflow-ai/cmux/actions/runs/23086348083

---

Summary by cubic

Fix CI build failures on the macOS 14 compatibility lane and refresh app support config tests. Build now succeeds with Xcode 16.2, and tests validate GhosttyApp.cmuxAppSupportConfigURLs using real files.

• Bug Fixes

  • Call the text input selection update via a dynamic selector when available, avoiding missing AppKit symbols in Xcode 16.2.

• Refactors

  • Replace stale release-app-support tests with file-backed coverage for GhosttyApp.cmuxAppSupportConfigURLs, including fallback, preference, non-debug skip, and ignoring empty/missing files.

^{Written for commit 545c5ac. Summary will update on new commits.}

Summary by CodeRabbit

• Bug Fixes
  • Improved text input handling to prevent potential crashes on certain system configurations while maintaining selection update functionality.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmux	Ready	Preview, Comment	Mar 15, 2026 5:29am

[greptile-apps]

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a08d7217-b856-4e00-8740-229ded634326

📥 Commits

Reviewing files that changed from the base of the PR and between 6c203b5 and 545c5ac.

📒 Files selected for processing (2)

• Sources/GhosttyTerminalView.swift
• cmuxTests/GhosttyConfigTests.swift

---

📝 Walkthrough

Walkthrough

Modified invalidateTextInputCoordinates to dynamically call textInputClientDidUpdateSelection using runtime selector checks instead of compile-time availability gates. Updated GhosttyConfigTests with focused test cases for app support configuration URL behavior and added helper utilities for test isolation.

Changes

Cohort / File(s)	Summary
Text Input Coordination Sources/GhosttyTerminalView.swift	Changed selection change notification to use runtime selector checks (responds(to:) and perform(_:)) instead of macOS 15.4 availability gates, calling textInputClientDidUpdateSelection only when selection actually changes.
Configuration Tests cmuxTests/GhosttyConfigTests.swift	Replaced test suite with focused cases validating cmuxAppSupportConfigURLs behavior, including release config fallback logic and empty config handling. Added helper utilities withTemporaryAppSupportDirectory and writeAppSupportConfig for improved test isolation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Fix macOS dictation NSTextInputClient conformance #1410: Both PRs modify GhosttyTerminalView.swift's text input coordination for textInputClientDidUpdateSelection selection notifications using macOS 15.4 selector handling.
• Fix voice dictation text insertion path in GhosttyNSView. #857: Both PRs affect text-input and selection handling in GhosttyTerminalView.swift with related NSTextInputClient coordination.

Poem

🐰 Selection dances at runtime's call,
No compile gates to block it all,
Tests now flourish with helper care,
Dynamic checks float through the air! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check	❓ Inconclusive	The title 'Fix main CI regressions' is overly generic and vague, lacking specificity about what CI regressions were fixed or which files were changed.	Use a more specific title that describes the main changes, such as 'Fix macOS 14 compatibility and update app support config tests' to clearly communicate the changeset.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description covers the Summary and Testing sections with clear details about the changes and how they were tested, meeting the template requirements.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch task-fix-main-cicd

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

No issues found across 2 files