Skip to content

Fix duplicate Running and Needs input sidebar states - #14493

Open
austinywang wants to merge 9 commits into
mainfrom
issue-12928-sidebar-dual-agent-state
Open

austinywang wants to merge 9 commits into
mainfrom
issue-12928-sidebar-dual-agent-state

Conversation

@austinywang

@austinywang austinywang commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Closes #12928

The sidebar now selects one current status for each panel when an agent's Running row overlaps Feed's Needs input row. Feed overlays use their recorded panel ownership, so a waiting panel does not hide a running agent on another panel. Regression tests cover both cases.

Validation: Swift syntax and PBX test wiring pass. A local harness executing the production display filter reproduces the original duplicate and the cross-panel regression, then passes both at 9b1ea16cff19d37fd23ac38bbabfb97dc16834d7. This does not establish app-host or UI coverage. Localization audit: no new product strings; existing English and Japanese Needs input translations remain in use.

Hosted tests are pending. Tagged build and UI verification are blocked: backend provisioning rejects the 320-instance limit, and the fleet controller rejects its installed credential with HTTP 401. No build job was created and this PR is not verified for merge.

Conflict-only gate passed for base 64b150b477d8f74d42ca7a4160676637bbf67694 and head 9b1ea16cff19d37fd23ac38bbabfb97dc16834d7.

— AmberWick12928 (registration pending)
run: run_issue12928_20260925_resume
session: issue-12928-sidebar-dual-agent-state-resume-1112f44ed4

@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: c8c3f65d-9df2-41e4-a20b-601be9fe56f2

📥 Commits

Reviewing files that changed from the base of the PR and between ceae537 and 9cbbfeb.

📒 Files selected for processing (2)
  • Sources/Workspace+SidebarStatusVisibility.swift
  • cmuxTests/WorkspaceSidebarObservationTests.swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@cursor

cursor Bot commented Sep 25, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Related: #14942 retires the Feed's Needs input overlay when Claude moves past a prompt answered in the terminal (Claude keeps the PermissionRequest hook running after a terminal answer, so the overlay otherwise lasts until the ~120 s hook deadline).

On its own, this PR's timestamp arbitration would show only Needs input after the answer: set_status keeps an unchanged Running value's first timestamp (shouldReplaceStatusEntry), so the overlay stays newer. With #14942 the overlay is gone by then, so the two compose; this one still covers the seconds of a real wait before Claude's own permission notification.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Automatic catch-up couldn't merge main (fc39e4c0ab56): Sources/Workspace+SidebarStatusVisibility.swift (both sides changed the same lines). Nothing was pushed; merge it by hand. A new push or /catch-up tries again.

Label no-auto-catch-up to opt out · Catch-up run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.64.25 sidebar shows "Running" and "Needs input" agent states at once

2 participants