Repository navigation
Fix duplicate Running and Needs input sidebar states - #14493
austinywang wants to merge 9 commits into
Conversation
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Related: #14942 retires the Feed's Needs input overlay when Claude moves past a prompt answered in the terminal (Claude keeps the PermissionRequest hook running after a terminal answer, so the overlay otherwise lasts until the ~120 s hook deadline). On its own, this PR's timestamp arbitration would show only Needs input after the answer: 🤖 Generated with Claude Code |
|
Automatic catch-up couldn't merge Label |
Closes #12928
The sidebar now selects one current status for each panel when an agent's Running row overlaps Feed's Needs input row. Feed overlays use their recorded panel ownership, so a waiting panel does not hide a running agent on another panel. Regression tests cover both cases.
Validation: Swift syntax and PBX test wiring pass. A local harness executing the production display filter reproduces the original duplicate and the cross-panel regression, then passes both at
9b1ea16cff19d37fd23ac38bbabfb97dc16834d7. This does not establish app-host or UI coverage. Localization audit: no new product strings; existing English and Japanese Needs input translations remain in use.Hosted tests are pending. Tagged build and UI verification are blocked: backend provisioning rejects the 320-instance limit, and the fleet controller rejects its installed credential with HTTP 401. No build job was created and this PR is not verified for merge.
Conflict-only gate passed for base
64b150b477d8f74d42ca7a4160676637bbf67694and head9b1ea16cff19d37fd23ac38bbabfb97dc16834d7.— AmberWick12928 (registration pending)
run: run_issue12928_20260925_resume
session: issue-12928-sidebar-dual-agent-state-resume-1112f44ed4