Repository navigation
ci: name the merged pull request behind each new main full-suite failure #14436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
13ac8f9
ci: attribute new main full-suite failures to merged pull requests (t…
teamleaderleo c7a7a51
ci: wire new-failure attribution into the main full-suite report
teamleaderleo 721c1e0
ci: grade the attribution baseline, rank at each merge, keep the sync…
teamleaderleo 85ed8bd
ci: read xcodebuild's Failing tests block for batches the ratchet doe…
teamleaderleo 853120c
ci: compare new failures shard by shard against the baseline
teamleaderleo 9ba909a
ci: give up per-shard comparison when the shard packing changed
teamleaderleo b23dcb7
ci: look past a baseline whose shard numbers no longer name the same …
teamleaderleo d5a446e
ci: count the batch runner among the shard packing inputs
teamleaderleo d9cecd1
test: register the attribution tests on the linux-guard lane
teamleaderleo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Add a step-level
timeout-minutesto the attribution step.continue-on-error: truecovers step failure only. It does not cover the job timeout. The attribution step can take a long time or hang: it makes up to nine rounds of log reads throughgh api, fetches blobs on demand from the partial clone, and diffs up to 40 pull requests withgit. If it runs past the 20-minute job limit, GitHub cancels the job. The step "Open, update or close the tracking issue" then never runs. This breaks the guarantee stated on Line 160. Set a step timeout that leaves time for the issue sync.🐛 Proposed fix
- name: Attribute new failures to merged pull requests # A report-only heuristic: its failure must not stop the issue sync. continue-on-error: true + # Leaves the rest of the job's 20 minutes for the issue sync. + timeout-minutes: 14📝 Committable suggestion
🤖 Prompt for AI Agents