Repository navigation
ci: run a tart-* pick as auto while the Tart VMs are offline #14416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 45671
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 45671
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 42728
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 42831
Charge Tart fallbacks to the selected pool.
When
CI_TART_FLEETis not1,resolve()rewritestart-*toauto, so the run can start on a Blacksmith pool. The workflow title still records the Tart input.e2e_by_pool()stores that run undertart-*, butpr_runner_pool.decide()discards non-usableplacedkeys before calculating demand. A later stale-snapshot decision can therefore ignore an in-flight fallback run and add avoidable queueing. Replay these fallback runs as routed demand or map them to the resolved pool before callingpr_runner_pool.decide().🤖 Prompt for AI Agents
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 18773
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 45670
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 23271
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 18219
🏁 Script executed:
Repository: manaflow-ai/cmux
Length of output: 41690
Gate Tart defaults in both resolvers.
When
requestedis"auto"or a disabled-fleet Tart request is rewritten to"auto",variablecan still provide atart-*label. E2E returns that value unchanged, and iOS places it directly inRoute.labelandruns_on.The workflows provide these defaults through
vars.MACOS_RUNNER_TESTSandvars.MACOS_RUNNER_TESTS || vars.MACOS_RUNNER_IOS. An unsetvars.CI_TART_FLEETbecomes an empty value, which disables the fleet gate.The existing runner-label policy can report invalid repository-variable values, but it does not prevent these resolver paths from using a Tart default. The Tart identity checks run only after a job has been assigned, so they cannot prevent a job from queuing on an offline fleet.
Apply the default gate in both resolvers:
🐛 Suggested fix
🤖 Prompt for AI Agents