test: tie the E2E stale-snapshot case to OWNED_MAX_AGE_MINUTES - #14348
Merged
Merged
Conversation
#14341 raised OWNED_MAX_AGE_MINUTES from 20 to 45, so a 30 minute old snapshot is now fresh enough and the "snapshot too old" case in test_run_e2e takes the owned Mac, failing app-host-execution guards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
rustybret
pushed a commit
to rustybret/bmux
that referenced
this pull request
Sep 25, 2026
cbe0bd9 ci: seed the macOS 15 pool with its own Xcode (manaflow-ai#14315) 5fab6f5 refactor: move CmuxWebView into CmuxBrowser behind an injected host (manaflow-ai#14321) 8475872 Merge pull request manaflow-ai#14335 from manaflow-ai/13458-safe-device-rollout 2f7bd16 fix(ios): accept the Mac's push key exchange (device id) and allow Simulator push verification (manaflow-ai#14292) fd66cc7 ci: give an owned Mac's second compile slot its own canonical root (manaflow-ai#14338) af4097b ci: build cmuxTests without the compilation cache so it rebuilds incrementally (manaflow-ai#14349) fe61107 ci: replay input times onto an owned Mac's kept DerivedData (manaflow-ai#14346) f7b8848 Freeze the historical socket migration in the rollback fixture 73c3a07 fix(web): store sandbox for production-bundle installs that declare it (manaflow-ai#14296) c04616b Merge remote-tracking branch 'origin/main' into 13458-safe-device-rollout 459d89c ci: read the owned pools' free machines live through the org route App (manaflow-ai#14350) 2b7afe3 ci: give the iOS upload workflows the R2 cache URL (manaflow-ai#14347) 359f14c test: tie the E2E stale-snapshot case to OWNED_MAX_AGE_MINUTES (manaflow-ai#14348) 1fcef82 Update CI guard expectations and require the passing layout regression 9b5a251 Merge remote-tracking branch 'origin/main' into 13458-safe-device-rollout 60ab69a Exercise remote mirror pane replacement in the workspace regression 7a0ba5d Merge remote-tracking branch 'origin/main' into 13458-safe-device-rollout 1649314 Preserve remote Mac workspaces across sidebar creation and pane replacement 52fec11 Observe asynchronous remote cleanup in the creation regression a93af4d Reproduce remote workspace deletion when its local placeholder is replaced bc0a0ad Test sidebar workspace creation preserves the remote Mac target 93aff4d ci: quote development Worker revision arguments 24475c2 Merge remote-tracking branch 'origin/main' into 13458-safe-device-rollout 57331a9 fix: make Devices rollout preserve SQLite rollback compatibility 448eeb2 test: reproduce unsafe Devices rollout assumptions # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/ci.yml # .github/workflows/ios-appstore-upload.yml # .github/workflows/ios-testflight.yml # .github/workflows/iroh-v2-production-drift.yml # .github/workflows/iroh-v2.yml # .github/workflows/seed-derived-data.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#14341 raised
OWNED_MAX_AGE_MINUTESfrom 20 to 45.tests/test_run_e2e.pystill hard-codesage=30for its "snapshot too old" case, so that snapshot now counts as fresh and the test fails. That turnsguards / workflow-guard-tests / app-host-executionred on main and on PRs (for example, #14338 and #14346).The case now uses
OWNED_MAX_AGE_MINUTES + 1.Tests:
python3 -m unittest tests.test_run_e2e(101) passes.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Ties the E2E stale-snapshot test case to the actual
OWNED_MAX_AGE_MINUTESconstant so the test stays valid when the value changes. Previously the test hard-coded age 30, which broke afterOWNED_MAX_AGE_MINUTESwas raised to 45.Written for commit 3dfc85f. Summary will update on new commits.
Summary by CodeRabbit