Repository navigation
ci: count the 12vcpu macOS pool at 5 machines - #14330
Conversation
… queue Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe 12-vCPU macOS 26 runner pool capacity changes from four machines to five. The documentation and pool-routing tests update their capacity, queue, occupancy, and replay expectations. Changes12-vCPU Runner Capacity
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The five-machine capacity and its documented routing expectations are aligned; no actionable merge-blocking risk is established. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
488b058 ci: count the 12vcpu macOS pool at 5 machines, the most it ran with a queue (manaflow-ai#14330) bcb162c Merge pull request manaflow-ai#14121 from manaflow-ai/issue-13640-terminal-paste-latency 24efd87 test(focus-recovery): run the automatic apply against a pinned tiny surface (manaflow-ai#14322) 57d3d7c Merge pull request manaflow-ai#14293 from manaflow-ai/issue-14290-directory-unavailable-stale e1a5ea3 ci: never abandon a run the owned pool rescue cancelled (manaflow-ai#14326) a76f47a web: contain Hexclave failures on every page (manaflow-ai#14316) fc7f80d ci: start macOS compile admission beside the fast Linux jobs (manaflow-ai#14314) 85f3d9f ci: roll a PR run over to the next pool when one is full (manaflow-ai#14323) 04e8a05 ci: let E2E runs take an owned Mac with a free slot (manaflow-ai#14311) 034025f reload: resolve the cmux-tui client before the build (manaflow-ai#14313) 7472de4 fix: pass projected resource to stale cwd resolver 9045f37 Merge remote-tracking branch 'origin/main' into issue-14290-directory-unavailable-stale 51a9004 fix: retain accepted Cloud cwd while stale 97d44fd test: retain known Cloud cwd during stale refresh f6df46e fix: retain rich text fallback for lossy paste data f3f43ed fix: retain rich text fallback for lossy paste data 5d8258b test: preserve rich paste fallback and text fidelity a9c54ba fix: keep mixed rich text paste on the fast plain-text path d284b6a test: cover fast paste for mixed plain and HTML clipboard # Conflicts: # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/ci-owned-pool-rescue.yml # .github/workflows/ci.yml # .github/workflows/test-e2e.yml
#14323 counted
blacksmith-12vcpu-macos-26at 4 machines. The janitor's snapshots from 2026-09-24 show it running 5 at once several times while jobs were queued behind it (21:18Z, 22:17Z, 22:40Z, 23:28Z), and 7 once. At 4 the picker sends a run to 6vcpu even when 12vcpu has a machine free.A pool with any job queued still counts as full, however many are running, so a queue on 12vcpu sends the run to the next pool either way. The capacity only decides when an unqueued pool counts as full.
POOL_CAPACITIES: 12vcpu goes from 4 to 5.docs/ci-runners.mdis updated to match.Tests (Python only):
test_ci_pr_runner_pool68 OK andtest_run_e2e95 OK. Pinned counts moved from 4 to 5, and a new E2E case covers rerouting when a queue is present.🤖 Generated with Claude Code
Summary by cubic
Raises the counted capacity of the 12vcpu macOS runner pool from 4 to 5 in
POOL_CAPACITIESso the picker uses a free 12vcpu machine instead of rolling runs over to 6vcpu. Janitor snapshots show the pool ran 5 machines at once several times with jobs queued behind it, so counting 4 filled the pool before it actually was. Docs and tests are updated to match, and an E2E case now covers routing runs off 12vcpu when a queue is present.Written for commit 6b2a6bc. Summary will update on new commits.
Summary by CodeRabbit