Repository navigation
Fix Computer Use onboarding readiness after permissions are granted - #14281
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
Automatic catch-up: I tried to catch this branch up with
Nothing was pushed. Merge Automatic catch-up will not try this head again; a new push or |
|
Automatic catch-up: I tried to catch this branch up with
Nothing was pushed. Merge Automatic catch-up will not try this head again; a new push or |
|
Merge receipt for |
541c735 fix(remote): reject unknown Eternal Terminal equals options (manaflow-ai#15987) ecb963b fix(cli): reject trailing remotes list/remove arguments (manaflow-ai#15978) 17a8a94 ci: pass the frame pacing fling count as an argument (manaflow-ai#16617) aa6f57e app sign-ins confirm the account, so sign out then sign in can pick another one (manaflow-ai#16661) 4adc8e4 Fix updater readiness wait reset loop (manaflow-ai#16664) 6f77178 Keep only Invite in Cloud sidebar header (manaflow-ai#16636) 72f2915 notify: add --desktop flag to post to the panel without a native banner (manaflow-ai#14688) 4ba0d8a Expose per-surface prompt and unread state to custom sidebars (manaflow-ai#11142) b3da20c Allow browser drags across Cloud workspaces (manaflow-ai#16390) 6529dfd Stop retrying Cloud terminals on stale replay daemons (manaflow-ai#16327) b10f7e2 test: create the requested cwd in the stale-reported split test (manaflow-ai#16653) 9b5b35f Fix Computer Use onboarding readiness after permissions are granted (manaflow-ai#14281) c45da7e Merge pull request manaflow-ai#16623 from manaflow-ai/fix-ios-cloudvpn-appstore-signing 6e67724 fix: close CloudVPN profile and identity gaps 7e9d6ab fix: sign CloudVPN in App Store exports 1984d1e test: cover App Store CloudVPN signing # Conflicts: # .github/workflows/cmux-next-frame-pacing.yml # .github/workflows/ios-app-store.yml # .github/workflows/ios-appstore-upload.yml
Fixes #14048. When the standalone helper reports both required TCC grants, promote a stale persisted onboarding phase to ready so the daemon publishes external permission readiness and MCP startup succeeds. Direct screen-capture consent remains separate. Added a regression test for the phase transition.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes #14048. When the standalone helper reports both accessibility and screen-recording TCC grants, promote a stale persisted onboarding phase to ready so the daemon publishes external permission readiness and MCP startup succeeds. Direct screen-capture consent remains separate.
Stops serializing the CUA socket auth token into Claude's argv-visible MCP config; the bundled client now inherits it from the environment so same-user processes can't read it via
ps..onboarding→.readyphase transition.Written for commit 4a1ea33. Summary will update on new commits.