Skip to content

Fix Computer Use onboarding readiness after permissions are granted - #14281

Merged
austinywang merged 3 commits into
mainfrom
issue-14048-computer-use-onboarding
Oct 2, 2026
Merged

austinywang merged 3 commits into
mainfrom
issue-14048-computer-use-onboarding

Conversation

@austinywang

@austinywang austinywang commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #14048. When the standalone helper reports both required TCC grants, promote a stale persisted onboarding phase to ready so the daemon publishes external permission readiness and MCP startup succeeds. Direct screen-capture consent remains separate. Added a regression test for the phase transition.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes #14048. When the standalone helper reports both accessibility and screen-recording TCC grants, promote a stale persisted onboarding phase to ready so the daemon publishes external permission readiness and MCP startup succeeds. Direct screen-capture consent remains separate.

Stops serializing the CUA socket auth token into Claude's argv-visible MCP config; the bundled client now inherits it from the environment so same-user processes can't read it via ps.

  • Adds a regression test for the .onboarding → .ready phase transition.

Written for commit 4a1ea33. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 8 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 441699d1-817c-4658-b579-4e052016b499

📥 Commits

Reviewing files that changed from the base of the PR and between ae5c960 and 4a1ea33.

📒 Files selected for processing (2)
  • Resources/bin/cmux-claude-wrapper
  • tests/test_claude_wrapper_hooks.py
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@github-actions

Copy link
Copy Markdown
Contributor

Automatic catch-up: main is green again and this branch needed it.

I tried to catch this branch up with main (e0e635e38fbb), but these files need a person:

  • Packages/macOS/CmuxComputerUse/Sources/CmuxComputerUse/ComputerUseRuntimeService.swift: not a generated file; needs a person

Nothing was pushed. Merge main locally, fix those, and push; /catch-up is there again whenever you want it.

Automatic catch-up will not try this head again; a new push or /catch-up does.
Label the pull request no-auto-catch-up to opt out.

Catch-up run

@github-actions

Copy link
Copy Markdown
Contributor

Automatic catch-up: main is green again and this branch needed it.

I tried to catch this branch up with main (e0e635e38fbb), but these files need a person:

  • Packages/macOS/CmuxComputerUse/Sources/CmuxComputerUse/ComputerUseRuntimeService.swift: not a generated file; needs a person

Nothing was pushed. Merge main locally, fix those, and push; /catch-up is there again whenever you want it.

Automatic catch-up will not try this head again; a new push or /catch-up does.
Label the pull request no-auto-catch-up to opt out.

Catch-up run

@teamleaderleo teamleaderleo added bug Something isn't working help wanted Nobody on the team is working on this and we would take a patch S3: minor Wrong behavior with a workaround area: agents Agent integrations (Claude Code, Codex, ACP), agent chat, hooks, status difficulty:3 Systems: multiple components or a runtime lifecycle labels Sep 30, 2026
@austinywang
austinywang merged commit 9b5b35f into main Oct 2, 2026
54 checks passed
@austinywang
austinywang deleted the issue-14048-computer-use-onboarding branch October 2, 2026 03:23
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Merge receipt for 4a1ea33ad5: every check was green at merge (10 verified; 13 skipped by policy). Full suite runs on main after merge.

rustybret pushed a commit to rustybret/bmux that referenced this pull request Oct 2, 2026
541c735 fix(remote): reject unknown Eternal Terminal equals options (manaflow-ai#15987)
ecb963b fix(cli): reject trailing remotes list/remove arguments (manaflow-ai#15978)
17a8a94 ci: pass the frame pacing fling count as an argument (manaflow-ai#16617)
aa6f57e app sign-ins confirm the account, so sign out then sign in can pick another one (manaflow-ai#16661)
4adc8e4 Fix updater readiness wait reset loop (manaflow-ai#16664)
6f77178 Keep only Invite in Cloud sidebar header (manaflow-ai#16636)
72f2915 notify: add --desktop flag to post to the panel without a native banner (manaflow-ai#14688)
4ba0d8a Expose per-surface prompt and unread state to custom sidebars (manaflow-ai#11142)
b3da20c Allow browser drags across Cloud workspaces (manaflow-ai#16390)
6529dfd Stop retrying Cloud terminals on stale replay daemons (manaflow-ai#16327)
b10f7e2 test: create the requested cwd in the stale-reported split test (manaflow-ai#16653)
9b5b35f Fix Computer Use onboarding readiness after permissions are granted (manaflow-ai#14281)
c45da7e Merge pull request manaflow-ai#16623 from manaflow-ai/fix-ios-cloudvpn-appstore-signing
6e67724 fix: close CloudVPN profile and identity gaps
7e9d6ab fix: sign CloudVPN in App Store exports
1984d1e test: cover App Store CloudVPN signing

# Conflicts:
#	.github/workflows/cmux-next-frame-pacing.yml
#	.github/workflows/ios-app-store.yml
#	.github/workflows/ios-appstore-upload.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: agents Agent integrations (Claude Code, Codex, ACP), agent chat, hooks, status bug Something isn't working difficulty:3 Systems: multiple components or a runtime lifecycle help wanted Nobody on the team is working on this and we would take a patch S3: minor Wrong behavior with a workaround

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0.64.25 Computer Use stuck in "onboarding is still in progress" after both permissions granted

2 participants