Repository navigation
canary: measure checksum-only rebuilds at cmux scale (do not merge) - #14256
Closed
teamleaderleo wants to merge 3 commits into
Closed
teamleaderleo wants to merge 3 commits into
teamleaderleo wants to merge 3 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Pins that every build-for-testing in compile-app-host-test-product.sh runs with FileSystemMode=checksum-only and that the seed fingerprint changes with the mode. Fails on this commit: FileSystemMode is unset and the fingerprint is the device-agnostic one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…real changes A seeded compile admission reran 94 SwiftDriver and 64 SwiftEmitModule tasks even for a seed of its own base commit (run 36022099083, seed distance 0). The XCBuild debugging trace names the inputs: 1,616 Xcode SDK and toolchain files whose mtime differs between Blacksmith images, and the generated package module maps Xcode rewrites with identical bytes on the first build after adoption. Every third-party package re-emitted its module for them. Build with Swift Build's FileSystemMode=checksum-only, set only in the environment of these xcodebuild invocations, so llbuild compares contents. A database written in one mode reruns every task in the other, so the mode joins the seed fingerprint. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
force-pushed
the
canary/checksum-only-probe
branch
from
September 24, 2026 16:43
689ad21 to
18b36db
Compare
Collaborator
Author
|
Canary done (run 36029379921): numbers are in #14262. Closing; do not merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measurement canary for ci/seed-module-reemit. Do not merge; I'll close it once the admission job reports.
It builds with the fix (Swift Build
FileSystemMode=checksum-onlyfor the admission builds), then rebuilds three times in the same job:The fingerprint changes with the mode, so this admission misses the seed and compiles cold under checksum-only.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds a measurement canary for the checksum-only seed fix. Do not merge; it will be closed once the admission job reports.
The admission build now runs Swift Build with
FileSystemMode=checksum-onlyso llbuild compares inputs by content. Without it, an adopted seed at distance 0 still reran 94 SwiftDriver and 64 SwiftEmitModule tasks because 1,616 Xcode SDK and toolchain files carry different mtimes across Blacksmith images, and generated package module maps get rewritten with identical bytes on the first build after adoption. The mode is set only in the environment of thesexcodebuildinvocations and joins the seed fingerprint, since a database written in one mode reruns everything in the other.Written for commit 18b36db. Summary will update on new commits.