Repository navigation
canary: measure what one app edit costs cmuxTests, cache on and off (do not merge) - #14249
Closed
teamleaderleo wants to merge 3 commits into
Closed
teamleaderleo wants to merge 3 commits into
teamleaderleo wants to merge 3 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
…do not merge) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cmuxTests rebuilds fully Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
force-pushed
the
canary/cmuxtests-incremental-probe
branch
from
September 25, 2026 01:24
551159e to
30293f8
Compare
This was referenced Sep 25, 2026
Collaborator
Author
|
Measurements done. Results and the fix are in #14349. |
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measurement canary. Do not merge; I'll close it once the admission job reports.
Why
A PR that changes the app module
cmux(cmux_DEV) usually recompiles all 1,091cmuxTestsfiles: 129 s median on 12vcpu, 199 s on 6vcpu. #14235 showed that an mtime-only touch of an app file is cheap (50 s) and that the asset-timestamp case (fixed by #14241) is a real full rebuild. It did not measure real content edits.What it does
After the normal admission compile, it rebuilds
cmux-unitin three series, each a baseline, a null rebuild, then cumulative edits:privatefunc in that fileGPUSpinner(one test file names it)Workspace(239 test files name it)cmuxTestsfileSeries:
cached(today's CI settings),uncached(COMPILATION_CACHE_ENABLE_CACHING=NO, explicit modules on,-driver-show-incremental),uncached-implicit(alsoSWIFT_ENABLE_EXPLICIT_MODULES=NO). The step summary reports per-target span, SwiftCompile counts, timing summary rows and incremental remarks; raw logs are uploaded.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Measurement canary only—do not merge. Adds a post-compile probe that rebuilds
cmux-unitafter cumulative app and test edits to measurecmuxTestsincremental costs with its compilation cache enabled, disabled, and disabled with explicit modules off.cmux-numeric-locale.cmuxTestswhile leaving other targets cached, records incremental remarks for cached rebuilds, and adds a cached-short control series.Written for commit 30293f8. Summary will update on new commits.