ci: remove the nightly Mac mini lane; nightlies build on Blacksmith - #14243
Merged
Merged
Conversation
Reverts the owned-Mac nightly route (#14208, #14223, #14233). There is no separate nightly lane or fallback: nightlies build on Blacksmith until Glaeda routing (glaeda#1174) sends every job std > light > Blacksmith > GitHub-hosted. nightly.yml is back to its pre-lane Blacksmith path, keeping the later nightly Sparkle key change (#14215). Signing, notarization and publication are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
teamleaderleo
added a commit
that referenced
this pull request
Sep 24, 2026
The pilot retirement kept scripts/ci/mini_dispatch.py for the nightly mini route, which #14243 has since removed. Delete the helper, its test and their registrations, and stop describing either lane as a direct-host exception. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
added a commit
that referenced
this pull request
Sep 24, 2026
The pilot retirement kept scripts/ci/mini_dispatch.py for the nightly mini route, which #14243 has since removed. Delete the helper, its test and their registrations, and stop describing either lane as a direct-host exception. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo
added a commit
that referenced
this pull request
Sep 24, 2026
* ci: retire the persistent Mac PR compile pilot The pilot never routed a pull request: CI_PERSISTENT_MAC_COMPILE is unset and every router run exited on it. Owned minis will serve pull request jobs through the pool picker (scripts/ci/pr_runner_pool.py, #14205) instead, in a follow-up that adds them to POOLS. Removed: persistent-macos-compile.yml, persistent-macos-router.yml, persistent_mac_route.py, run-persistent-mac-compile.py, persistent_compile_fleet.py, scripts/persistent-compile and their tests; the route request steps in ci.yml; the observe, download and revalidate steps in ci-macos.yml, with the source_identity_valid and source_tree inputs only they read; the producer exemption in the fleet-runner guard. Kept: the nightly owned-Mac route. The helpers nightly_mini_route.py loaded from persistent_mac_route.py move to scripts/ci/mini_dispatch.py unchanged apart from dropping the PR-only dispatch method, with their RetryWait tests in tests/test_ci_mini_dispatch.py. With CI_PERSISTENT_MAC_COMPILE unset the removed steps were all skipped, so hosted compile admission behaves as before. Its metrics artifact drops the pilot-only fields and moves to schema_version 2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: link the pilot retirement PR in mac-fleet.md Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: drop the owned-Mac dispatch helper now that no lane uses it The pilot retirement kept scripts/ci/mini_dispatch.py for the nightly mini route, which #14243 has since removed. Delete the helper, its test and their registrations, and stop describing either lane as a direct-host exception. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: drop stale owned-Mac producer and pilot mentions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: count #14244's owned-pool guard in the capability-label plan Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * ci: refuse the retired pilot's bare label, and say how minis take PR jobs Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Leo decided there is no separate nightly lane and no nightly fallback path. Routing for every job will be std mini > light mini > Blacksmith > GitHub-hosted once Glaeda owns it (glaeda#1174). Until then nightlies build on Blacksmith, as they did before #14208.
What is removed
This reverts #14208, #14223 and #14233:
.github/workflows/nightly-mini-build.ymlscripts/ci/nightly_mini_route.pyandtests/test_nightly_mini_route.pynightly.yml: theroute-nightly-minijob, themac_minidispatch input, theAdopt owned-Mac productsstep and the!cancelled()/ explicit-result gates the optional route job needed.nightly.ymlnow matches its pre-lane version exactly, plus the later nightly Sparkle key change (ci: let the nightly channel sign with its own Sparkle key #14215).check_nightly_mini_lane, thenightly-mini-build.ymlexemption and thecmux-nightly-miniprobes intests/test_ci_self_hosted_guard.sh; the route test step inci-guards.yml; the registry, change-area and guard-group entries; the matching expectations intests/test_nightly_universal_build.shNIGHTLY_MAC_MINIand "Nightly lane" text inCLAUDE.md,docs/ci-runners.mdanddocs/ci/mac-fleet.md.mac-fleet.mdkeeps one line: nightlies run on Blacksmith until Glaeda routing (glaeda#1174) sends every job std > light > Blacksmith > GitHub-hosted.Signing, notarization and publication are untouched.
scripts/ci/mini_dispatch.pydoes not exist on main (#14232 adds it), so there is nothing to remove there.Overlap with #14232
#14232 (draft) keeps the nightly route and moves its helpers into
scripts/ci/mini_dispatch.py. Whichever lands second dropsnightly_mini_route.py,tests/test_nightly_mini_route.pyand the nightly parts ofmini_dispatch.py. Hunks here touch only nightly-lane lines; the persistent compile text in the same files is left as is.After merge (not in this PR)
Delete the
cmux-nightly-minirunner group, the cmux15-nightly runner registration and theNIGHTLY_MAC_MINI*repository variables.Tests
Run locally, all passing:
tests/test_nightly_universal_build.sh,tests/test_ci_self_hosted_guard.sh,tests/test_ci_change_areas.py,tests/test_ci_test_execution_registry.py,scripts/ci/validate_test_execution_registry.py,tests/test_ci_workflow_guards_are_wired.py,tests/test_ci_workflow_run_sources.py,tests/test_ci_fork_runner_routing.py,tests/test_runner_label_policy.py,tests/test_ci_persistent_mac_compile.py, andactionlintover all workflows.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Removes the nightly owned-Mac mini lane; nightlies now build on Blacksmith until Glaeda routing (glaeda#1174) sends every job std > light > Blacksmith > GitHub-hosted. This reverts #14208, #14223 and #14233.
Removed
.github/workflows/nightly-mini-build.yml,scripts/ci/nightly_mini_route.pyand their tests.route-nightly-minijob,mac_minidispatch input and product-adoption step, which returnnightly.ymlto its pre-lane state plus the nightly Sparkle key change.NIGHTLY_MAC_MINIand "Nightly lane" docs, keeping one line inmac-fleet.mdstating nightlies build on Blacksmith until Glaeda routing.Signing, notarization and publication are unchanged. After merge, delete the
cmux-nightly-minirunner group, the nightly runner registration and theNIGHTLY_MAC_MINI*repository variables.Written for commit 85908a3. Summary will update on new commits.