Skip to content

ci: pin the Glaeda candidate that accepts cmux's current Xcode pins - #14213

Merged
teamleaderleo merged 1 commit into
manaflow-ai:mainfrom
teamleaderleo:ci/glaeda-candidate-59ca9c9
Sep 24, 2026
Merged

teamleaderleo merged 1 commit into
manaflow-ai:mainfrom
teamleaderleo:ci/glaeda-candidate-59ca9c9

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

scripts/persistent-compile up cannot enroll any mini on current main. The pinned Glaeda candidate 36e07e36 stops at bootstrap with bootstrap does not allow enrollment: xcodePin. Its check wanted .xcode-version to read 26.0, and #14050 changed the file to 26 today. This came up on the #13491 canary on an M4 Pro mini.

teamleaderleo/glaeda#1155 (merged) fixes it:

  • the pin check compares majors
  • mini-setup's Xcode default follows CMUX_CI_XCODE_APP_PR to /Applications/Xcode_26.6.app
  • a headless mini with a licensed Xcode no longer needs the Command Line Tools

This PR replaces the four CANDIDATE_* values with that build:

Testing

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Updates the pinned Glaeda candidate in scripts/ci/persistent_compile_fleet.py so scripts/persistent-compile up can enroll minis on current main. The old candidate rejected all checkouts at bootstrap because its xcodePin check required .xcode-version to read 26.0, while #14050 set it to 26. The new candidate (teamleaderleo/glaeda#1155) compares majors instead and also updates the artifact's expiry date.

Written for commit aff0401. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Chores
    • Refreshed the reviewed build candidate and extended its availability window. This update does not change product functionality, the interface, or user workflows; no new capabilities or behavior changes are included.

The pinned candidate 36e07e36 refused every current checkout at bootstrap:
its xcodePin check wanted .xcode-version to read "26.0", and manaflow-ai#14050 made it
"26". teamleaderleo/glaeda#1155 compares majors instead. Candidate run
35991372390 builds 59ca9c9 (tree 5b89b9c0) and expires 2026-10-24. Found on
the manaflow-ai#13491 canary.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Sep 24, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2f936aeb-1ea5-4a96-b2e7-ca52efecb937

📥 Commits

Reviewing files that changed from the base of the PR and between ad5ea20 and aff0401.

📒 Files selected for processing (1)
  • scripts/ci/persistent_compile_fleet.py

Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The persistent compile fleet now pins a new Glaeda candidate run, source revision, checksum, and expiration. The artifact name is unchanged.

Changes

Glaeda candidate pin

Layer / File(s) Summary
Update candidate constants
scripts/ci/persistent_compile_fleet.py
The candidate run, source revision, SHA-256 checksum, and expiration were updated. The artifact name remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to aff04

The updated candidate pin matches its build source and archive checksum, and invalid artifacts are rejected before use. No actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 25
✅ Passed checks (25 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: pinning a Glaeda candidate that supports cmux's current Xcode pins.
Description check ✅ Passed The description includes a concrete problem statement, resulting behavior, candidate details, testing results, and canary verification. The Demo Video section is not needed because this is a CI artifa…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input ✅ Passed PASS: The pull request changes only four Glaeda candidate constants in scripts/ci/persistent_compile_fleet.py. It does not change Cloud terminal creation, cmux-tui transport, manual renderer admissi…
Cmux Swift Actor Isolation ✅ Passed PASS: The pull request changes only four Glaeda candidate constants in scripts/ci/persistent_compile_fleet.py. The authoritative diff contains no Swift, Objective-C, or Objective-C++ files, so it in…
Cmux Swift Blocking Runtime ✅ Passed PASS: The pull request changes only four Glaeda candidate constants in scripts/ci/persistent_compile_fleet.py. It introduces no Swift code and no semaphores, blocking waits, sleeps, delayed dispatch…
Cmux Browser Automation Off-Main ✅ Passed PASS: The pull request changes only four Glaeda candidate constants in scripts/ci/persistent_compile_fleet.py. It does not change browser.* commands, Sources/TerminalController.swift, `ControlCo…
Cmux Expensive Synchronous Load ✅ Passed PASS: The pull request changes only four Glaeda candidate constants in scripts/ci/persistent_compile_fleet.py. The authoritative diff contains no Swift changes and no agent-history, transcript, JSON…
Cmux Cache Substitution Correctness ✅ Passed PASS: The pull request changes only four artifact-pin constants in scripts/ci/persistent_compile_fleet.py, a Python file. It does not change production Swift, TypeScript, or JavaScript code, and it …
Cmux No Hacky Sleeps ✅ Passed PASS. The pull request changes only four Glaeda candidate metadata constants in scripts/ci/persistent_compile_fleet.py: run, source, SHA-256, and expiration. It adds no sleep, timer, polling, retry,…
Cmux Algorithmic Complexity ✅ Passed The pull request changes only four literal Glaeda candidate constants in scripts/ci/persistent_compile_fleet.py: run, source, SHA-256, and expiration. It adds no loops, collection scans, sorting, fi…
Cmux Swift Concurrency ✅ Passed PASS: The authoritative PR diff changes only scripts/ci/persistent_compile_fleet.py, replacing four Glaeda candidate metadata constants. It contains no Swift, Objective-C, or Objective-C++ changes, …
Cmux Swift @Concurrent ✅ Passed PASS: The pull request changes only scripts/ci/persistent_compile_fleet.py, updating Glaeda candidate metadata. The authoritative diff contains no Swift changes or Swift async functions, so the `@co…
Cmux Swift Package Boundaries ✅ Passed PASS: The pull request changes only scripts/ci/persistent_compile_fleet.py, a Python CI script. The diff contains no production Swift changes or Swift package-boundary changes, so this check is not …
Cmux Swiftpm Lockfiles ✅ Passed PASS: The PR changes only four Glaeda candidate constants in scripts/ci/persistent_compile_fleet.py. The authoritative diff contains no Package.swift, Package.resolved, .gitignore, Xcode proje…
Cmux Swift Logging ✅ Passed The pull request changes only four Glaeda artifact-pin constants in scripts/ci/persistent_compile_fleet.py. The authoritative diff contains no Swift files and adds no print, debugPrint, dump, …
Cmux User-Facing Error Privacy ✅ Passed PASS. The diff only rotates four Glaeda artifact constants in scripts/ci/persistent_compile_fleet.py. The values flow through the internal mini enrollment and persistent compile fleet operator comma…
Cmux Full Internationalization ✅ Passed PASS. The PR changes only four Glaeda candidate pin values in scripts/ci/persistent_compile_fleet.py: run ID, source commit, SHA-256, and expiration. These are CI artifact/configuration tokens used …
Cmux Swiftui State Layout ✅ Passed PASS: The pull request changes only scripts/ci/persistent_compile_fleet.py. The diff rotates four Glaeda candidate constants and contains no Swift or SwiftUI code, so the SwiftUI state/layout check …
Cmux Architecture Rethink ✅ Passed PASS: The PR changes only four Glaeda candidate constants in scripts/ci/persistent_compile_fleet.py. The diff contains no changed Swift files and introduces no architectural lifecycle mechanisms. Th…
Cmux Swift Auxiliary Window Close Shortcuts ✅ Passed PASS: The pull request changes only scripts/ci/persistent_compile_fleet.py. The diff updates four Glaeda candidate constants and contains no Swift window, panel, controller, or SwiftUI window change…
Cmux Source Artifacts ✅ Passed The PR changes only the tracked source script scripts/ci/persistent_compile_fleet.py. The diff updates four candidate pin constants and does not add local output, logs, screenshots, recordings, temp…
Cmux No Test Or Debug Seam In Production Source ✅ Passed PASS: The pull request changes only scripts/ci/persistent_compile_fleet.py. It changes Glaeda candidate pin constants and adds no Swift file under a production Sources/ path. The custom check does…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit 4e35c3e into manaflow-ai:main Sep 24, 2026
43 checks passed
rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 24, 2026
dd7ea7c ci: let the nightly channel sign with its own Sparkle key (manaflow-ai#14215)
b9d4df0 ci: reject errno read inside a Swift test assertion (manaflow-ai#14054)
4e35c3e ci: pin the Glaeda candidate that accepts cmux's current Xcode pins (manaflow-ai#14213)
1c1d27b ci: try the nightly app compile on an owned Mac mini first, Blacksmith fallback (manaflow-ai#14208)
1fc4b83 refactor: move the surface catalog's value types into a package (manaflow-ai#13135)
2ee69dd refactor: move 38 leaf mobile-host files into a CmuxMobileHost package (manaflow-ai#14093)
ad5ea20 test(ssh): assert the cmux-tui open flow for TTY cmux ssh (manaflow-ai#14204)
03d3759 test: repair the app-host suites that fail only on macOS 26 (manaflow-ai#13988)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant