ci: pin the Glaeda candidate that accepts cmux's current Xcode pins - #14213
Conversation
The pinned candidate 36e07e36 refused every current checkout at bootstrap: its xcodePin check wanted .xcode-version to read "26.0", and manaflow-ai#14050 made it "26". teamleaderleo/glaeda#1155 compares majors instead. Candidate run 35991372390 builds 59ca9c9 (tree 5b89b9c0) and expires 2026-10-24. Found on the manaflow-ai#13491 canary. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe persistent compile fleet now pins a new Glaeda candidate run, source revision, checksum, and expiration. The artifact name is unchanged. ChangesGlaeda candidate pin
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The updated candidate pin matches its build source and archive checksum, and invalid artifacts are rejected before use. No actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dd7ea7c ci: let the nightly channel sign with its own Sparkle key (manaflow-ai#14215) b9d4df0 ci: reject errno read inside a Swift test assertion (manaflow-ai#14054) 4e35c3e ci: pin the Glaeda candidate that accepts cmux's current Xcode pins (manaflow-ai#14213) 1c1d27b ci: try the nightly app compile on an owned Mac mini first, Blacksmith fallback (manaflow-ai#14208) 1fc4b83 refactor: move the surface catalog's value types into a package (manaflow-ai#13135) 2ee69dd refactor: move 38 leaf mobile-host files into a CmuxMobileHost package (manaflow-ai#14093) ad5ea20 test(ssh): assert the cmux-tui open flow for TTY cmux ssh (manaflow-ai#14204) 03d3759 test: repair the app-host suites that fail only on macOS 26 (manaflow-ai#13988)
Summary
scripts/persistent-compile upcannot enroll any mini on currentmain. The pinned Glaeda candidate36e07e36stops at bootstrap withbootstrap does not allow enrollment: xcodePin. Its check wanted.xcode-versionto read26.0, and #14050 changed the file to26today. This came up on the #13491 canary on an M4 Pro mini.teamleaderleo/glaeda#1155 (merged) fixes it:
CMUX_CI_XCODE_APP_PRto/Applications/Xcode_26.6.appThis PR replaces the four
CANDIDATE_*values with that build:glaeda-candidate-aarch64-apple-darwin)59ca9c9bd1bb56679aabbde994fd8f3e55fee935(tree5b89b9c0d589a89eab8b718bc917731094fc7a8e)f31ab3a17feb1d8d955c5527f193478a1c871790ab2ea67058b0f9d4e2395b55, checked against the downloaded archiveTesting
python3 tests/test_ci_persistent_compile_fleet.py: 69 tests pass.eligibleForEnrollment: trueagainst cmuxmain. Before the fix it reportedxcodePin. The acceptance receipt will be posted on First M4 Pro mini canary: bring one mini up with one command #13491.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Updates the pinned Glaeda candidate in
scripts/ci/persistent_compile_fleet.pysoscripts/persistent-compile upcan enroll minis on currentmain. The old candidate rejected all checkouts at bootstrap because itsxcodePincheck required.xcode-versionto read26.0, while #14050 set it to26. The new candidate (teamleaderleo/glaeda#1155) compares majors instead and also updates the artifact's expiry date.Written for commit aff0401. Summary will update on new commits.
Summary by CodeRabbit