test: pin which terminal tabs get an agent mark after #14062

[teamleaderleo]

Follow-up to #14062. No product code changes behavior here; this documents one visible change #14062 made and closes three test gaps it left.

Behavior change from #14062, now pinned. A restored tab shows its agent's mark only while the restored agent command is running (autoResumeCommandRunning or observedAgentCommandRunning). So after relaunch, a tab that is still waiting to auto-resume, or that offers a manual resume, looks like a plain terminal until the agent starts. Before #14062 those tabs showed the agent mark from the restored snapshot. The new restoredAgentThatHasNotResumedGetsNoAgentMark() pins both states.

Test gaps in TerminalTabIconRegressionTests:

• fix: drop a restored agent's tab mark once the agent quits #14062 deleted agentProcessTitleKeepsReleaseTerminalIcon, the only test of feat(tui): adopt Herdr-style agent plugins and journal projections #13299's rule that a title which merely looks like an agent (codex --yolo) gets no mark. agentLookingTitleGetsNoAgentMark() restores it against current behavior. TerminalTabAgentIconResolver.titleStatusKey(from:) had no callers, so it's removed.
• restoredAgentThatQuitToTheShellLeavesNoAgentMark() could pass without a mark ever being applied. It now asserts the resumed agent marks the tab (AgentIcons/Codex) before it quits.

scripts/ci/app-host-known-failures.json still listed activeAgentKeepsReleaseTerminalIcon(statusKey:), which #14062 deleted; the entry is gone. validate-catalog, catalog-diff against main (20 -> 19) and tests/test_ci_app_host_result_accounting.py pass locally.

Validation: the new tests are Swift app-host tests; the changed-suites lane runs TerminalTabIconRegressionTests on this PR. I haven't run them against an inverted assertion.

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

---

Summary by cubic

Follow-up to #14062 that pins a visible behavior change and closes three test gaps in TerminalTabIconRegressionTests; no product behavior changes.

• Restored tabs now show an agent mark only while the restored agent command runs, so tabs awaiting auto-resume or offering manual resume show no mark until the agent starts.
• Re-added a test pinning that a title that merely looks like an agent (codex --yolo) gets no mark, and removed the now-unused titleStatusKey(from:).
• The quit-to-shell test now asserts the resumed agent marks the tab before quitting, so it can't pass vacuously.
• Removed the stale known-failure entry for the deleted activeAgentKeepsReleaseTerminalIcon(statusKey:).

^{Written for commit 332bc69. Summary will update on new commits.}

[coderabbitai]

Warning

Review limit reached

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7a92f9a2-4529-4680-bee3-23d2200c0b8e

📥 Commits

Reviewing files that changed from the base of the PR and between 7ae086f and 332bc69.

📒 Files selected for processing (3)

• Sources/TerminalTabAgentIcon.swift
• cmuxTests/TerminalTabIconRegressionTests.swift
• scripts/ci/app-host-known-failures.json

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}