Repository navigation
Fix main compile: read matchingObservation after its declaration in Workspace restore check - #14130
Merged
Merged
Conversation
… check The Codex restore-intent early return landed on the same line as the effectiveRestorableAgent guard and reads matchingObservation, which is declared a few lines later, so main stopped compiling: "use of local variable 'matchingObservation' before its declaration". Move the check below the declaration. The intervening statements only compute values, so the early return behaves exactly as intended. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
azooz2003-bit
enabled auto-merge (squash)
September 24, 2026 03:48
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe agent-running heuristic now checks ChangesAgent liveness
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The ordering fix addresses the reported build error without an identified change to session restore behavior. It is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
Full details: Description checkExplanation The description clearly explains the compile error, the code change, the reason for the change, and the local build verification. It does not follow the required template structure and omits the Review Trigger and Checklist sections. A Demo Video is not needed because this is a compile fix rather than a UI or behavior change. Resolution Reformat the description using the repository template. Add Summary and Testing headings, include the Review Trigger block, and complete the Checklist with the applicable testing, coverage, documentation, bot-review, and comment-resolution items.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 24, 2026
Collaborator
|
GREAT CATCH I WILL JUST MERGE THISI ASAP |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main does not compile:
Sources/Workspace.swift:640:211: error: use of local variable 'matchingObservation' before its declaration. The Codex restore-intent early return (from 36c3050) was spliced onto theeffectiveRestorableAgentguard line by a concurrent merge and readsmatchingObservation, which is declared a few lines later. This moves the check directly below the declaration; the intervening statements only compute values, so the early return behaves as intended. Verified with a local tagged Debug build of the app target. Follows #14123 (the missing import from the same commit).🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes main not compiling: the Codex restore-intent early return read
matchingObservationbefore its declaration. Moves the check below the declaration; the statements in between only compute values, so the early return behaves as intended.Written for commit 85287d3. Summary will update on new commits.
Summary by CodeRabbit