Skip to content

test: prove managed Claude teammate wrapper handoff - #14070

Closed
austinywang wants to merge 1 commit into
mainfrom
issue-13822-wrapper-proof
Closed

austinywang wants to merge 1 commit into
mainfrom
issue-13822-wrapper-proof

Conversation

@austinywang

@austinywang austinywang commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The managed teammate regression could pass if the launcher bypassed its wrapper and invoked the configured Claude executable directly. Export a marker inside the wrapper and require it in the agent stand-in, proving the actual handoff ran.

Addresses the actionable review finding on #13844 for #13822. No runtime changes.

Testing

All four polling regression sections pass against the CLI built from head 75854b3ac6303049c43618516fe2afa8998f37ce. Controller job 456da964d710b165a7db7149 succeeded, cleanup confirmed; published tag pr-14070-teammates-v1. Artifact SHA-256: 9fef8e58be46aa8f4a11761f1018bb5ae883c829024b73e54d6394a52eedf44d.

Two fresh workspaces on the isolated tagged socket passed the actual managed-launch/tmux integration sequence: targeted discovery, one detached teammate split, leader focus preserved, and unique output produced in the new terminal. The Claude process was deterministic; real Claude Code 2.1.280 reached interactive login, which was not automated. No visual or authenticated real-Claude proof is claimed.

Normal PR checks passed. Focused hosted wrapper test: https://github.com/manaflow-ai/cmux/actions/runs/35942257134 (passed; 1 Swift Testing test executed).

Demo Video

Not applicable: test-only change. CLI/debug-socket evidence is recorded above; no visual proof is claimed.

Review Trigger

Automatic reviews completed. No manual reviewer trigger was requested.

Checklist

  • Ran the focused regression against the final built CLI.
  • Updated behavioral test coverage.
  • iOS soak coverage is not applicable.
  • No product documentation or changelog change is needed.
  • Addressed actionable automatic review findings.
  • No unresolved human review comments.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Proves the managed teammate flow actually ran through the wrapper instead of invoking the configured Claude executable directly, closing a gap where the regression test could pass on a bypassed launcher. Exports a marker in the wrapper and requires it in the agent stand-in; test-only, no runtime changes. Addresses the review finding on #13844 for #13822.

Written for commit 75854b3. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Tests
    • Expanded coverage of the managed Claude wrapper to verify that the expected environment marker is set before the configured Claude binary runs. The stand-in agent now checks for the marker before proceeding with its other validations.

@cursor

cursor Bot commented Sep 24, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 26f42a02-9133-470f-982e-ed4b2a05702e

📥 Commits

Reviewing files that changed from the base of the PR and between 2c2314e and 75854b3.

📒 Files selected for processing (1)
  • tests/test_cli_tmux_compat_targeted_read_budget.py

Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review.


📝 Walkthrough

Walkthrough

The managed Claude wrapper test now sets an environment marker before invoking the configured Claude binary. The stand-in agent checks that the marker is present after startup.

Changes

Managed wrapper test

Layer / File(s) Summary
Wrapper marker check
tests/test_cli_tmux_compat_targeted_read_budget.py
The wrapper sets CMUX_TEST_MANAGED_WRAPPER_RAN=1 before invoking the configured Claude binary. The stand-in agent checks for the marker after startup.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 75854

The test now checks that the managed wrapper ran. No identified issue prevents merging after normal checks.

🚥 Pre-merge checks | ✅ 25
✅ Passed checks (25 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input ✅ Passed PASS: The pull request changes only tests/test_cli_tmux_compat_targeted_read_budget.py. It adds an environment marker in a test wrapper and asserts that the stand-in agent receives it. The diff does…
Cmux Swift Actor Isolation ✅ Passed PASS: The PR changes only one Python test file (+2 lines) and introduces no Swift or production code changes. The added lines export and assert a managed-wrapper marker in the test stand-in, so the Sw…
Cmux Swift Blocking Runtime ✅ Passed The PR changes only tests/test_cli_tmux_compat_targeted_read_budget.py. It adds an environment marker in the test wrapper and checks that marker in the stand-in agent. The diff contains no productio…
Cmux Browser Automation Off-Main ✅ Passed PASS: The pull request changes only tests/test_cli_tmux_compat_targeted_read_budget.py. The diff adds an environment marker to a managed Claude wrapper test and checks it in the stand-in agent. It a…
Cmux Expensive Synchronous Load ✅ Passed The pull-request range changes only tests/test_cli_tmux_compat_targeted_read_budget.py. It adds an environment marker in a test wrapper and checks that marker in the test agent. No Swift files or pr…
Cmux Cache Substitution Correctness ✅ Passed PASS: The authoritative pull-request diff changes only tests/test_cli_tmux_compat_targeted_read_budget.py, a Python test file. It introduces no production Swift, TypeScript, or JavaScript change and…
Cmux No Hacky Sleeps ✅ Passed PASS. The authoritative diff changes only tests/test_cli_tmux_compat_targeted_read_budget.py. It adds an environment marker in a test-created shell wrapper and an assertion in the test stand-in. The…
Cmux Algorithmic Complexity ✅ Passed PASS. The PR changes only tests/test_cli_tmux_compat_targeted_read_budget.py (+2 lines). Both lines add an environment marker to a generated shell wrapper and assert it in a generated test agent. Th…
Cmux Swift Concurrency ✅ Passed PASS: The review-scoped diff changes only tests/test_cli_tmux_compat_targeted_read_budget.py. It adds a shell marker export and an assertion in the test stand-in. No Swift files or cmux-owned Swift …
Cmux Swift @Concurrent ✅ Passed PASS: The authoritative PR diff changes only tests/test_cli_tmux_compat_targeted_read_budget.py, a Python test file. It adds an environment marker check and contains no Swift changes or async/`@co…
Cmux Swift Package Boundaries ✅ Passed PASS: The pull request changes only tests/test_cli_tmux_compat_targeted_read_budget.py, a Python test fixture. It introduces no production Swift code, so the Swift package-boundary rule is not appli…
Cmux Swiftpm Lockfiles ✅ Passed PASS. The pull request changes only tests/test_cli_tmux_compat_targeted_read_budget.py. It does not change a SwiftPM package, Package.resolved, an Xcode project package reference, a .gitignore, …
Cmux Swift Logging ✅ Passed The pull request changes only tests/test_cli_tmux_compat_targeted_read_budget.py. It adds an environment marker in a shell-test wrapper and checks that marker in the test stand-in agent. No Swift fi…
Cmux User-Facing Error Privacy ✅ Passed PASS. The authoritative diff changes only tests/test_cli_tmux_compat_targeted_read_budget.py. It adds a test-only environment marker and an assertion in the stand-in Claude agent. The rule explicitl…
Cmux Full Internationalization ✅ Passed The pull request changes only tests/test_cli_tmux_compat_targeted_read_budget.py. It adds a test environment marker and an assertion in a stand-in agent. The internationalization rule explicitly all…
Cmux Swiftui State Layout ✅ Passed PASS: The pull request changes only tests/test_cli_tmux_compat_targeted_read_budget.py and adds two shell-test assertions. The diff contains no Swift or SwiftUI changes, so the SwiftUI state-layout …
Cmux Architecture Rethink ✅ Passed The check applies only to Swift architecture changes. The pull request changes one Python test file and adds test-only environment-marker assertions. The authoritative diff contains no Swift files and…
Cmux Swift Auxiliary Window Close Shortcuts ✅ Passed The pull request changes only tests/test_cli_tmux_compat_targeted_read_budget.py, a Python test file. The diff contains no Swift changes and no cmux-owned window code. The auxiliary-window close-sho…
Cmux Source Artifacts ✅ Passed The PR changes only tests/test_cli_tmux_compat_targeted_read_budget.py (+2 lines). The additions export and verify a marker inside an intentional managed-wrapper test fixture. The path is a tracked …
Cmux No Test Or Debug Seam In Production Source ✅ Passed PASS: The pull request changes only tests/test_cli_tmux_compat_targeted_read_budget.py. It changes no Swift file under a production Sources/ path, so it cannot introduce a production test or debug…
Title check ✅ Passed The title clearly identifies the main change: testing the managed Claude teammate wrapper handoff.
Description check ✅ Passed The description explains what changed and why, documents detailed testing, addresses the demo video requirement as not applicable, and includes the required checklist with all applicable items marked …
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant