Repository navigation
test: prove managed Claude teammate wrapper handoff - #14070
austinywang wants to merge 1 commit into
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe managed Claude wrapper test now sets an environment marker before invoking the configured Claude binary. The stand-in agent checks that the marker is present after startup. ChangesManaged wrapper test
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Merge Risk: ⚪ Minimal · up to The test now checks that the managed wrapper ran. No identified issue prevents merging after normal checks. 🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
The managed teammate regression could pass if the launcher bypassed its wrapper and invoked the configured Claude executable directly. Export a marker inside the wrapper and require it in the agent stand-in, proving the actual handoff ran.
Addresses the actionable review finding on #13844 for #13822. No runtime changes.
Testing
All four polling regression sections pass against the CLI built from head
75854b3ac6303049c43618516fe2afa8998f37ce. Controller job456da964d710b165a7db7149succeeded, cleanup confirmed; published tagpr-14070-teammates-v1. Artifact SHA-256:9fef8e58be46aa8f4a11761f1018bb5ae883c829024b73e54d6394a52eedf44d.Two fresh workspaces on the isolated tagged socket passed the actual managed-launch/tmux integration sequence: targeted discovery, one detached teammate split, leader focus preserved, and unique output produced in the new terminal. The Claude process was deterministic; real Claude Code 2.1.280 reached interactive login, which was not automated. No visual or authenticated real-Claude proof is claimed.
Normal PR checks passed. Focused hosted wrapper test: https://github.com/manaflow-ai/cmux/actions/runs/35942257134 (passed; 1 Swift Testing test executed).
Demo Video
Not applicable: test-only change. CLI/debug-socket evidence is recorded above; no visual proof is claimed.
Review Trigger
Automatic reviews completed. No manual reviewer trigger was requested.
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Proves the managed teammate flow actually ran through the wrapper instead of invoking the configured Claude executable directly, closing a gap where the regression test could pass on a bypassed launcher. Exports a marker in the wrapper and requires it in the agent stand-in; test-only, no runtime changes. Addresses the review finding on #13844 for #13822.
Written for commit 75854b3. Summary will update on new commits.
Summary by CodeRabbit