Repository navigation
Prevent repeated Computer Use helper launch dialogs - #14028
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe helper launch configuration now validates the helper executable and sets its launch options, arguments, and environment. The runtime service uses this configuration and returns ChangesHelper launch
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change prevents invalid helpers from triggering repeated launch dialogs. No actionable regression remains identified before merge. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1963a38 fix: attribute task model catalog results (manaflow-ai#13876) 148666c Prevent repeated Computer Use helper launch dialogs (manaflow-ai#14028)
Background Computer Use helper launch failures can repeatedly display Finder alerts in shipped stable v0.64.25 and nightly 3589434697901. Computer Use defaults to enabled, and both releases retain the affected launch and health-recovery path. The reported local incident showed launchd denying execution with errno 13 roughly every four seconds; the exact permission or security check responsible for that denial has not been established.
Reject missing, non-regular, or non-executable helpers before launch, and set
NSWorkspace.OpenConfiguration.promptsUserIfNeeded = falseso other launch errors return through the completion handler without requiring dismissal. This changes background error handling while preserving helper permissions and macOS security checks.Validation:
git diff --checkpassed.Tagged verification remains blocked: remote backend provisioning refused at its disk floor. The explicit offline build
e760fa4c5c1197b98b3e2106then failed before compilation because the fleet recipe passes mutually exclusiveCMUX_DEV_BACKEND_MODE=localandCMUX_DEV_BACKEND_URL. Recorded as controller feedbackfe7ae0229e736f04c0501574. No tagged app or GUI failure-path reproduction is available. The source fix has not shipped.Affected users can stop helper retries by disabling Settings > Computer Use > Enable Computer Use. The remote Computer Use UX flag only controls onboarding/status UI and does not stop the runtime.