Skip to content

test(ios): expect the construction focus event in composer diagnostics #14003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Sep 23, 2026
Merged

test(ios): expect the construction focus event in composer diagnostics #14003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Packages/iOS/CmuxMobileShell/Tests/CmuxMobileShellTests/ComposerPendingAttachmentTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ import Testing
private static let terminalA = MobileTerminalPreview(id: "term-a", name: "a")
private static let terminalB = MobileTerminalPreview(id: "term-b", name: "b")

/// A composite selected on `term-a`. Selection is set by `init` (no `didSet`
/// draft swap fires), so the store contents stay exactly what each test seeds.
/// A composite selected on `term-a`. `init` leaves the selection to the
/// workspace synchronizer, which picks `term-a` and records one
/// `surfaceFocused` event. The draft swap it runs loads `term-a`'s empty
/// draft, so the store contents stay exactly what each test seeds.
private static func makeComposite(diagnosticLog: DiagnosticLog? = nil) -> MobileShellComposite {
MobileShellComposite(
workspaces: [
Expand Down Expand Up @@ -55,17 +57,21 @@ import Testing

let clock = ContinuousClock()
let deadline = clock.now.advanced(by: .seconds(1))
while await log.processedCount() < 3, clock.now < deadline {
while await log.processedCount() < 4, clock.now < deadline {
await Task.yield()
}
#expect(await log.processedCount() >= 3)
#expect(await log.processedCount() >= 4)
let report = await log.snapshot()
// The first event is construction focusing `term-a` (see
// `makeComposite`), not an attachment mutation.
#expect(report.events.map(\.a) == [
DiagnosticAppEventKind.surfaceFocused.rawValue,
DiagnosticAppEventKind.terminalAttachmentStaged.rawValue,
DiagnosticAppEventKind.terminalAttachmentRemoved.rawValue,
DiagnosticAppEventKind.terminalAttachmentRejected.rawValue,
])
#expect(report.events.map(\.b) == [
nil,
nil,
nil,
DiagnosticFailureKind.protocolViolation.rawValue,
Expand Down