Skip to content

ci(ios): bound the xcodebuild test invocation so a teardown wedge fails fast #13927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Sep 23, 2026
Merged

ci(ios): bound the xcodebuild test invocation so a teardown wedge fails fast #13927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/test-ios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,10 @@ jobs:
id: simulator-tests
env:
TEST_FILTER: ${{ inputs.test_filter }}
# Bounds one xcodebuild invocation. Generous against the ~2 minutes
# the non-UI suite actually takes, and well under the job's 35-minute
# ceiling so a wedge still leaves room for the steps after this one.
XCODEBUILD_TIMEOUT_SECONDS: "900"
run: |
set -euo pipefail
started_ns="$(python3 -c 'import time; print(time.monotonic_ns())')"
Expand Down Expand Up @@ -899,7 +903,14 @@ jobs:
xcrun simctl erase "$SIMULATOR_ID"
xcrun simctl boot "$SIMULATOR_ID" >/dev/null 2>&1 || true
xcrun simctl bootstatus "$SIMULATOR_ID" -b
if xcodebuild "${XCODEBUILD_ARGS[@]}" -resultBundlePath "$RESULT_PATH" 2>&1 | tee "$LOG_PATH"; then
# xctest can wedge in teardown once the run is over: it waits on a
# process termination that never lands, emits nothing further, and
# the only bound left is the job ceiling (#13918). Bound the
# invocation so that becomes a non-zero exit this loop can classify
# -- the cleanup-failure check below already knows how to tolerate a
# bad exit whose selected tests passed.
if scripts/blacksmith-bounded-command.sh "$XCODEBUILD_TIMEOUT_SECONDS" \
xcodebuild "${XCODEBUILD_ARGS[@]}" -resultBundlePath "$RESULT_PATH" 2>&1 | tee "$LOG_PATH"; then
./scripts/ci/require_selected_test_execution.sh \
"$LOG_PATH" \
"${TEST_FILTER:-}"
Expand Down
Loading