Repository navigation
Make the shortcut reference list every action the schema accepts - #13911
Conversation
skills/cmux-keyboard-shortcuts/SKILL.md tells agents "Do not invent action IDs. Validate against the schema or shortcut-actions.md." The reference listed 119 of the schema's 154 ids, so an agent binding openDiffViewer, openTeamPicker, newCloudMachine, markWorkspaceDone, sendCtrlFToTerminal, any of the 11 diffViewer* ids, or any of the four resize-pane-* ids was told it had invented a valid action. The file claimed to be auto-generated and was not. The 36 missing ids are added under their existing groups, plus one new "Markdown and diff viewer" group, and tests/test_cmux_settings_supported_paths.py now asserts the file and the schema enum agree in both directions. cmux-skill-contract.yml already triggers on web/data/cmux.schema.json, so the guard fires on the change that introduces drift rather than at the next audit. all-keys.md carried the same false "Auto-generated" header and also lags the schema. Its header now says what is true. Generating it properly needs type, default, and description extraction and is left as follow-up. Two unrelated fixes in the same surface: - skills/cmux-workspace/SKILL.md hand-set CMUX_SOCKET_PATH and invoked the ambient cmux binary, the exact path CLAUDE.md routes around because it "can target the user's main app socket". It now uses the scrubbed helper. - skills/cmux-review/SKILL.md referred to a vocabulary "already exercised by Cultist". That word appeared exactly once in the repository, so no reader could resolve it. Verified: the new assertion fails when an id is removed from the reference and passes when restored; the full file is 7/7 green; sync-test-wiring --check is ok across 1038 test files. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 14 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
Review — holds up, mergingDocs plus one guard test, all checks green, The reason this is worth landing rather than just correcting by hand: Reading the enum through Scope is contained: four skills markdown files and one existing test file. No product code, no workflow files, and no new Non-blocking: the file previously claimed to be auto-generated and wasn't. The test now enforces the invariant that claim implied, which is the more useful half, but a generator would still be cheaper than hand-maintaining 154 entries the next time a group is added. Worth doing only if this drifts again. Enabling auto-merge; required checks remain the gate. — Zarathustra g1 🌱 |
ca867b7 ci(ios): bound the xcodebuild test invocation so a teardown wedge fails fast (manaflow-ai#13927) 9ffbb6a ci: compile the E2E test product once, in its own job (manaflow-ai#13908) 827f614 ci: let the macOS 15 and 26 pools share one Swift package cache (manaflow-ai#13925) b79a83b Price GPT-6 models in coderouter API-equivalent estimates (manaflow-ai#13892) ff20a22 Expose in-flight drag intent to custom JavaScript sidebars (manaflow-ai#13841) 3344583 Capture Cloud Desktop click destinations before queued opens (manaflow-ai#13897) ac041c1 test(ios): assert the letterbox a daemon-push shrink actually produces (manaflow-ai#13920) ce1c55c Catch guard-group drift between ci.yml and GROUPS (manaflow-ai#13924) 3466781 ci: keep leading whitespace in workload profile git output (manaflow-ai#13883) 78e0d83 Make the shortcut reference list every action the schema accepts (manaflow-ai#13911) 94fc7e8 ci: stop buying a universal Release build for CI janitors and reporters (manaflow-ai#13912) b91fff1 fix(ios): restore the package conventions lint to green on main (manaflow-ai#13904) 6defb93 ci: skip the nightly publish when no changed path reaches the app (manaflow-ai#13899) c57b001 ci: let E2E runs seed the compilation cache from any revision on main (manaflow-ai#13900) # Conflicts: # .github/workflows/nightly.yml # .github/workflows/perf-activation.yml # .github/workflows/test-depot.yml # .github/workflows/test-e2e.yml # .github/workflows/test-ios.yml
skills/cmux-keyboard-shortcuts/SKILL.mdtells agents "Do not invent action IDs. Validate against the schema orshortcut-actions.md." The reference listed 119 of the schema's 154 ids, so an agent bindingopenDiffViewer,openTeamPicker,newCloudMachine,markWorkspaceDone,sendCtrlFToTerminal, any of the 11diffViewer*ids, or any of the fourresize-pane-*ids was told it had invented a valid action. The file claimed to be auto-generated and was not.Resulting behavior
The 36 missing ids are listed under their existing groups, plus one new
## Markdown and diff viewergroup.tests/test_cmux_settings_supported_paths.pynow asserts the reference andshortcuts.bindings.propertyNames.enumagree in both directions — a missing id and an id the schema rejects both fail.cmux-skill-contract.ymlalready triggers onweb/data/cmux.schema.json, so the guard runs on the change that introduces drift rather than at the next audit. No workflow change needed.Tradeoffs
all-keys.mdhad the same false "Auto-generated" header and also lags the schema. I corrected the header to state what is true rather than half-fix the content: regenerating it needs type, default, and description extraction, and hand-patching ~20 table rows would mean inventing descriptions. Left as follow-up.Two unrelated fixes in the same surface
skills/cmux-workspace/SKILL.mdhand-setCMUX_SOCKET_PATHand invoked the ambientcmuxbinary — the exact pathCLAUDE.mdroutes around because it "can target the user's main app socket". It now usesscripts/cmux-debug-cli.sh, which scrubs ambient terminal context.skills/cmux-review/SKILL.mdreferred to a vocabulary "already exercised by Cultist". That word appeared exactly once in the repository, so no reader could resolve it.Validation
python3 -m unittest tests.test_cmux_settings_supported_pathsis 7/7 green. The new assertion was confirmed to bite: deletingopenDiffViewerfrom the reference fails with "shortcut-actions.md is missing action ids the schema accepts", and restoring it passes../scripts/sync-test-wiring --checkreports ok across 1038 test files. Linux only — nothing here touches Swift or needs a macOS lane.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
The shortcut action reference now lists every action accepted by the schema, preventing valid action IDs from being rejected as invented. A bidirectional test catches both missing and unsupported IDs, while related skill documentation now uses the debug CLI and removes an unresolvable repository reference.
all-keys.md.Written for commit be7c2a1. Summary will update on new commits.