Skip to content

Add bounded collector for dev app backend diagnostics - #13910

Merged
lawrencecchen merged 2 commits into
mainfrom
feat-dev-backend-diagnostics-collector
Sep 23, 2026
Merged

lawrencecchen merged 2 commits into
mainfrom
feat-dev-backend-diagnostics-collector

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Land the independent collector from #13890 first so native app delivery can be verified while its macOS checks wait for a runner.

The fixed-schema route accepts only bounded development tag/revision, timing and outcome codes, applies the existing diagnostics rate limit before parsing, and acknowledges only after Axiom confirms the entire batch. The ingestion token stays server-side and the dataset is fixed. No authentication is required because the backend failure can itself prevent sign-in; records are untrusted operational observations, not account identities.

Validation: collector behavior tests, web typecheck and complexity gate passed. No database migration or existing endpoint changes. The server-only production ingestion credential is provisioned.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Adds a bounded, unauthenticated collection endpoint so tagged DEBUG apps can report development backend connection outcomes even when a backend failure prevents sign-in.

  • Accepts only a fixed versioned schema and applies the existing diagnostics rate limit before parsing.
  • Acknowledges only after Axiom confirms the entire batch; the ingestion token stays server-side.
  • Records are untrusted operational observations, not account identities.
  • No database migration or existing endpoint changes.

Written for commit d9703b8. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • New Features
    • Added diagnostic reporting for development backends, with validated event data and delivery acknowledgements.
    • On Vercel, diagnostic requests are subject to rate limits; requests are rejected if rate limiting is unavailable or not configured.
  • Documentation
    • Documented diagnostic retention, retries, consent, delivery, and the debug.dev_backend.check command.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 6211142c-8816-46e9-adc4-67e2814643f3

📥 Commits

Reviewing files that changed from the base of the PR and between cd3ce57 and d9703b8.

📒 Files selected for processing (4)
  • web/app/api/observability/dev-backend/route.ts
  • web/services/observability/DEV-BACKEND.md
  • web/services/observability/devBackendDiagnostics.ts
  • web/tests/dev-backend-diagnostics.test.ts
 ______________________________________________________________________________________________________________________
< You can't write perfect software. Software can't be perfect. Protect your code and users from the inevitable errors. >
 ----------------------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen
lawrencecchen merged commit af221f0 into main Sep 23, 2026
61 of 63 checks passed
rustybret pushed a commit to rustybret/bmux that referenced this pull request Sep 23, 2026
d726774 ci: default focused E2E dispatches to macOS 26 (manaflow-ai#13902)
6c7efe5 ci: reuse an in-flight focused run instead of dispatching over it (manaflow-ai#13901)
af221f0 Add bounded collector for dev app backend diagnostics (manaflow-ai#13910)
0f48984 ci: stop routing contributor prose to macOS and the release build (manaflow-ai#13905)
cd3ce57 test: respect build defaults in stable Cloud override assertions (manaflow-ai#13838)
197daa7 Fix default Codex ledger tilde expansion (manaflow-ai#13635)
e435dc0 fix: report the submitted prompt length, not the truncated preview's (manaflow-ai#13728)
9bd4c8d ci: route artifact transport helpers off the web and release lanes (manaflow-ai#13895)
7e72db9 Fix validation of unresolved workspace reorder targets (manaflow-ai#13843)
a9b0329 ci: gate native iOS work on package convention lint (manaflow-ai#13886)
bd50702 ci: skip docs deployment for standalone complexity policy (manaflow-ai#13887)
e786379 feat(cli): make workflow templates discoverable (manaflow-ai#13189)

# Conflicts:
#	.github/workflows/docs-channels.yml
#	.github/workflows/test-e2e.yml
#	.github/workflows/test-ios.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant