Repository navigation
CI: run Claude wrapper regressions without compiling the app - #13869
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe CI workflow adds standalone routing and a macOS test lane for Claude-wrapper changes. The change-area classifier excludes wrapper files from other routed CI areas. A self-test also updates the accepted pull request cancellation expressions. ChangesClaude wrapper CI
Pull request concurrency guard
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Sequence Diagram(s)sequenceDiagram
participant Changes as CI change routing
participant Job as claude-wrapper job
participant Lane as macos-claude-wrapper lane
participant Status as ci-status
Changes->>Job: Emit claude_wrapper route
Job->>Lane: Run wrapper test lane
Lane->>Status: Report job result
Status->>Status: Require success when route or full-suite condition applies
Merge Risk: ⚪ Minimal · up to No concrete issue remains that would prevent merging once the required CI checks pass. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 3 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The tests-only commit The implementation is being checked against the complete existing routing test suite before the second commit is pushed. |
|
Both hosted guard failures on I am extending the guard's recognized safe forms narrowly, with cases that reject disabling synchronize cancellation, rather than changing label reuse or creating another workflow to avoid the check. The repair will also incorporate current main normally. No native rerun has been dispatched. — FlintRail g1 🪄 |
Merge current main while preserving wrapper regression routing.
|
Pushed The obsolete failing run was cancelled and verified complete while its wrapper job was still queued. Normal auto-merge remains enabled behind required checks; this is not yet a hosted-green or merged result. — FlintRail g1 🪄 |
069f1ce ci: streamline app-host test consumers (manaflow-ai#13427) cfe69ec Merge pull request manaflow-ai#13885 from teamleaderleo/docs/full-ci-explicit-scope 25a6378 docs: require explicit broad-suite intent for full-ci 0a6c362 Merge pull request manaflow-ai#13749 from manaflow-ai/ci/app-host-product-fast-transport 3094a95 ci: overlap local Rust helper builds with nightly Swift compilation (manaflow-ai#13874) ea4b13b CI: run Claude wrapper regressions without compiling the app (manaflow-ai#13869) 8f1491b test: bound SSH fish helper pipe draining (manaflow-ai#13408) 9667375 Merge pull request manaflow-ai#13826 from manaflow-ai/12284-claude-wrapper-subcommands 40b0cd7 ci: scope trusted web complexity before Bun setup (manaflow-ai#13598) 0f0d4a7 ci(iOS): build simulator test product once (manaflow-ai#13600) 0f28e77 Merge main settings runtime repair for native validation 819adce Merge branch 'main' of https://github.com/manaflow-ai/cmux into 12284-claude-wrapper-subcommands 7442bf7 Merge remote-tracking branch 'origin/main' into 12284-claude-wrapper-subcommands b6507c7 Merge remote-tracking branch 'origin/main' into 12284-claude-wrapper-subcommands eed9ca5 Merge main to use corrected test execution and CI routing 645e8af test: control the Claude catalog cache clock 3c0637d Merge remote-tracking branch 'origin/main' into 12284-claude-wrapper-subcommands 6229cdc fix: expire successful Claude command discovery catalogs 6f775da test: require bounded Claude command cache freshness 2132e30 fix: preserve cancellation during Claude command discovery 7ac2789 Merge remote-tracking branch 'origin/main' into 12284-claude-wrapper-subcommands 8cc6659 fix: discover and cache Claude subcommands before hook injection 59dd108 test: cover Claude command discovery and fallback a9da704 ci: fall back cleanly on artifact decoder errors bfb744f test: reproduce artifact decoder failures escaping fallback a02abe7 ci: bound the suite coverage diagnostic job 8237edc Merge main and preserve the derived review-fabric contract group a982dec test: check review-fabric routing through the router, not its source text (manaflow-ai#13788) 0d16b9b Merge branch 'main' into ci/app-host-product-fast-transport 74b94e3 CI: read the app-host test product over parallel range requests # Conflicts: # .github/workflows/ci-artifact-transport.yml # .github/workflows/ci-guards.yml # .github/workflows/ci-macos.yml # .github/workflows/ci.yml # .github/workflows/nightly.yml # .github/workflows/test-ios.yml # .github/workflows/web-complexity-trusted.yml
Claude wrapper-only changes currently enter native CI even though their regression suite uses fake clients and a Unix socket. With compile-only routing, the app can compile without that wrapper suite ever running.
This PR gives the suite an independent macOS lane with Python and Node, without app compilation or artifact downloads. Exact wrapper/test changes avoid native lanes; mixed app changes retain them. The required CI aggregate requires successful execution when the wrapper lane is selected, and full-suite runs execute it once.
Validation: six behavioral regressions fail against the original workflow/classifier/registry and pass with the prepared fix. These execute routing shell, aggregate logic and the registry runner, including missing Node and skipped/cancelled/missing execution. The existing wrapper suite also passes standalone; actionlint passes. The tests-only commit failed on the intended aggregate regression in hosted CI. The implementation commit passes the complete
tests/test_ci_change_areas.pysuite locally, including all six new regressions and the existing routing cases; hosted validation is running. Normal auto-merge is enabled behind required checks.Related: #13826. Base:
10c952bc31a98ece2b715816c8312165680fb7bb. No app runtime change or native benchmark dispatch.Hosted follow-up exposed a cancellation-guard compatibility issue: the guard did not recognize the existing label/unlabel exception. The repair accepts only that exact PR expression; fixtures still reject synchronize exclusions, false clauses, and incorrect events. Existing label reuse and runtime cancellation are unchanged.
— FlintRail g1 🪄
Run: run_cmux_main_green_20260923_01a0bfb7
Intention: run wrapper regressions without app compilation and retain required CI evidence.
Summary by CodeRabbit