Repository navigation
ci: allow runner selection in the focused test helper - #13867
teamleaderleo merged 2 commits into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe focused-test dispatcher accepts an optional runner and includes it in dispatch requests. For explicit non-auto runners, prior-attempt matching considers runs recorded for that runner; the default and auto behavior retains the broad guard. ChangesFocused test runner selection
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to Runner selection and repeat protection appear ready to merge after normal checks; no actionable issue is established in the supplied evidence. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
@coderabbitai review |
✅ Action performedReview finished.
|
The focused-test helper cannot select a runner, so a macOS 26 verification requires a separate manual workflow dispatch. Its repeat guard also treats a prior macOS 15 failure as a reason to reject that macOS 26 run.
Add
--runnerwith the same choices astest-e2e.ymland pass an explicit choice into the workflow. For an explicit non-auto runner, prior failure and success history is matched against that runner as well as the existing selector and exact commit. Omitted/auto behavior stays unchanged.For example:
scripts/run-e2e.sh cmuxTests/ExampleTests --ref topic/fix --runner blacksmith-6vcpu-macos-26.Validation: 31 launcher tests pass against a fake GitHub CLI, including every workflow runner choice, default preservation, invalid-input rejection before GitHub access, cross-runner failure isolation, and same-runner repeat protection even when another runner succeeded. The tests fail before the implementation commit;
git diff --checkpasses. No native workflow was dispatched during verification.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Allows the focused test helper to select a runner, so a macOS 26 verification no longer needs a separate manual workflow dispatch.
--runnerwith the same choices astest-e2e.yml; omitting it keeps the workflow default.Written for commit fcc450b. Summary will update on new commits.
Summary by CodeRabbit
Final validation: all 31 focused CLI tests pass, independent review found no actionable issues, and CodeRabbit completed a clean review of
fcc450bd18d38811a55ac36afd6bd92f9b1b4dd9. Required checks are being reevaluated after the stable CLA/Web check-name fixes landed on main. No native simulator test dispatch was performed for this helper-only change.