Repository navigation
ci: require execution of selected Swift package tests - #13824
Conversation
|
Warning Review limit reachedNext included review available in 6 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
This comment has been minimized.
This comment has been minimized.
|
Fixed the current-head CI fixture failure in 46b98fc. The notification workflow fixture copied the package selector but omitted the new execution verifier, so the real workflow step failed before its assertions. The fixture now includes the production helper. Reproduced the exact missing-file failure locally, then all six notification workflow cases passed. Production behavior is unchanged by this follow-up. Hosted evidence: https://github.com/manaflow-ai/cmux/actions/runs/35805050027/job/107004073903 |
Swift package CI could pass while a failing top-level
@Testnever ran: the isolated runner extracted only suite-based test names. The targeted package route also discarded declared local dependencies outsidePackages/, so changes tovendor/bonsplitandvendor/stack-auth-swift-sdk-prereleaseskipped their consumers’ tests.The runner now preserves every discovered test using qualified filters. Package and Bonsplit commands require a completed, nonempty Swift Testing or XCTest result; XCTest’s overall completion is required and skipped tests do not count. The existing GhosttyKit diagnostic exception still accepts its known cosmetic error, but cannot turn empty tests or unrelated process failures green. Targeted routing uses the same transitive local-dependency graph as package selection, without turning unrelated CI edits into full package sweeps.
Validation:
ffdc50a6f9a0failed in hosted CI for both the dropped top-level test and ignored vendor dependency, before the fix commit.This strengthens test execution and selection. It does not claim macOS 26 runtime coverage or replace #13819’s pending real-app Gatekeeper verification. No app runtime code, runner allocation policy, or scheduled workflows change.