Repository navigation
Add /nightly page - #1378
Merged
Merged
Add /nightly page#1378
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (21)
📝 WalkthroughWalkthroughAdds a new localized Nightly builds page at /nightly, a footer link, a sitemap entry, and corresponding "nightly" translation entries across many locale JSON files. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant NextJS as Next.js Server
participant I18n as i18n Messages
participant Sitemap as Sitemap Generator
participant CDN as Download Host
Client->>NextJS: GET /nightly (locale in URL)
NextJS->>I18n: load translations for locale ("nightly")
I18n-->>NextJS: localized strings
NextJS-->>Client: render NightlyPage + metadata
NextJS->>Sitemap: include /nightly entry (build time)
Client->>CDN: Click download CTA -> fetch dmg
CDN-->>Client: serve nightly dmg
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/app/`[locale]/nightly/page.tsx:
- Around line 28-31: The logo image in the nightly page is decorative and its
current alt ("cmux icon") is redundant and not localized; update the <img>
element (the logo image in page.tsx) to use decorative-image semantics by
setting alt="" and adding aria-hidden="true" so screen readers ignore it (keep
existing props like src and width unchanged).
In `@web/messages/tr.json`:
- Around line 589-595: Update the Turkish strings to use proper apostrophe
joining for borrowed terms and suffixes: replace occurrences in the keys
metaDescription, description, detailSeparateApp, detailAutoBuilt and
detailAutoUpdates (e.g., "main deki" -> "main'deki", "commit ten" ->
"commit'ten", "bundle ID sine" -> "bundle ID'sine", "ID si" -> "ID'si") so that
suffixes attach with an apostrophe and stray spaces are removed; keep the
original meanings and punctuation while applying these apostrophes consistently
across the mentioned keys.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 31663e90-ba1f-40d6-a3aa-5e97cbf8ed8c
📒 Files selected for processing (22)
web/app/[locale]/components/site-footer.tsxweb/app/[locale]/nightly/page.tsxweb/app/sitemap.tsweb/messages/ar.jsonweb/messages/bs.jsonweb/messages/da.jsonweb/messages/de.jsonweb/messages/en.jsonweb/messages/es.jsonweb/messages/fr.jsonweb/messages/it.jsonweb/messages/ja.jsonweb/messages/km.jsonweb/messages/ko.jsonweb/messages/no.jsonweb/messages/pl.jsonweb/messages/pt-BR.jsonweb/messages/ru.jsonweb/messages/th.jsonweb/messages/tr.jsonweb/messages/zh-CN.jsonweb/messages/zh-TW.json
Comment on lines
+28
to
+31
| <img | ||
| src="/logo.png" | ||
| alt="cmux icon" | ||
| width={48} |
There was a problem hiding this comment.
Use decorative-image semantics for the logo.
On Line 30, alt="cmux icon" is redundant next to the visible heading and stays English on localized pages. Prefer decorative semantics (alt="" + aria-hidden) here.
♿ Suggested accessibility fix
<img
src="/logo.png"
- alt="cmux icon"
+ alt=""
+ aria-hidden="true"
width={48}
height={48}
className="rounded-xl"
/>📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| <img | |
| src="/logo.png" | |
| alt="cmux icon" | |
| width={48} | |
| <img | |
| src="/logo.png" | |
| alt="" | |
| aria-hidden="true" | |
| width={48} | |
| height={48} | |
| className="rounded-xl" | |
| /> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@web/app/`[locale]/nightly/page.tsx around lines 28 - 31, The logo image in
the nightly page is decorative and its current alt ("cmux icon") is redundant
and not localized; update the <img> element (the logo image in page.tsx) to use
decorative-image semantics by setting alt="" and adding aria-hidden="true" so
screen readers ignore it (keep existing props like src and width unchanged).
Comment on lines
+589
to
+595
| "metaDescription": "cmux NIGHTLY indirin. main deki en son commit ten otomatik olarak derlenen bağımsız bir uygulama. Kararlı sürümle yan yana çalışır ve kendi otomatik güncellemelerine sahiptir.", | ||
| "description": "cmux NIGHTLY, main deki en son commit ten otomatik olarak derlenir. Kendi bundle ID sine sahip olduğundan kararlı sürümle çakışmadan yan yana çalışır. Yeni özellikleri yayınlanmadan önce test etmek için kullanın.", | ||
| "download": "Mac için NIGHTLY indir", | ||
| "detailsHeading": "Nasıl çalışır", | ||
| "detailSeparateApp": "Kendi bundle ID si, simgesi ve tercihleri olan bağımsız uygulama", | ||
| "detailAutoBuilt": "main deki en son commit ten otomatik olarak derlenir", | ||
| "detailAutoUpdates": "Kararlı sürümden bağımsız kendi Sparkle akışı üzerinden otomatik güncelleme", |
There was a problem hiding this comment.
Fix Turkish apostrophe/spacing in Nightly copy.
On Line 589 onward, several strings miss standard Turkish apostrophe joining for borrowed terms and suffixes, which makes the UI text read unpolished.
✍️ Suggested text fixes
- "metaDescription": "cmux NIGHTLY indirin. main deki en son commit ten otomatik olarak derlenen bağımsız bir uygulama. Kararlı sürümle yan yana çalışır ve kendi otomatik güncellemelerine sahiptir.",
+ "metaDescription": "cmux NIGHTLY'yi indirin. main'deki en son commit'ten otomatik olarak derlenen bağımsız bir uygulama. Kararlı sürümle yan yana çalışır ve kendi otomatik güncellemelerine sahiptir.",
- "description": "cmux NIGHTLY, main deki en son commit ten otomatik olarak derlenir. Kendi bundle ID sine sahip olduğundan kararlı sürümle çakışmadan yan yana çalışır. Yeni özellikleri yayınlanmadan önce test etmek için kullanın.",
+ "description": "cmux NIGHTLY, main'deki en son commit'ten otomatik olarak derlenir. Kendi bundle ID'sine sahip olduğundan kararlı sürümle çakışmadan yan yana çalışır. Yeni özellikleri yayınlanmadan önce test etmek için kullanın.",
- "detailAutoBuilt": "main deki en son commit ten otomatik olarak derlenir",
+ "detailAutoBuilt": "main'deki en son commit'ten otomatik olarak derlenir",
- "warning": "Nightly derlemeler hatalar veya tamamlanmamış özellikler içerebilir. Bir sorun oluşursa GitHub da bildirin ve kararlı sürüme geçin."
+ "warning": "Nightly derlemeler hatalar veya tamamlanmamış özellikler içerebilir. Bir sorun oluşursa GitHub'da bildirin ve kararlı sürüme geçin."Also applies to: 598-598
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@web/messages/tr.json` around lines 589 - 595, Update the Turkish strings to
use proper apostrophe joining for borrowed terms and suffixes: replace
occurrences in the keys metaDescription, description, detailSeparateApp,
detailAutoBuilt and detailAutoUpdates (e.g., "main deki" -> "main'deki", "commit
ten" -> "commit'ten", "bundle ID sine" -> "bundle ID'sine", "ID si" -> "ID'si")
so that suffixes attach with an apostrophe and stray spaces are removed; keep
the original meanings and punctuation while applying these apostrophes
consistently across the mentioned keys.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bn-l
pushed a commit
to bn-l/cmux
that referenced
this pull request
Apr 3, 2026
* Add /nightly page with localized content for all 18 locales Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use actual nightly icon, remove Homebrew and How it works sections Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Change warning callout to plain text Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Remove subtitle from nightly page Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add GitHub and Discord #nightly-bugs links to warning text and README Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Lawrence Chen <lawrencecchen@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/nightlypage at cmux.dev/nightly with download link, Homebrew install instructions, how-it-works details, and a warning calloutTesting
SKIP_ENV_VALIDATION=1 npx next buildpasses, route renders at/[locale]/nightlyRelated
Summary by cubic
Added a
/nightlypage at cmux.dev/nightly with a Mac download and a plain-text safety warning that links to GitHub Issues and Discord#nightly-bugs, fully localized across all supported locales. It’s linked in the footer and sitemap, uses the nightly icon, removes the Homebrew and “How it works” sections and the subtitle, and adds the same reporting links to the README — making https://www.cmux.dev/nightly a real page.Written for commit 6571335. Summary will update on new commits.
Summary by CodeRabbit
New Features
Documentation