Rename v2 Workers and preserve legacy hostnames - #13768
azooz2003-bit wants to merge 5 commits into
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe canonical IROH v2 Worker hostnames and application origins now use the ChangesWorker rename and compatibility
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant LegacyClient
participant AliasWorker
participant CanonicalWorker
LegacyClient->>AliasWorker: Send request to former hostname
AliasWorker->>CanonicalWorker: Forward request through CANONICAL.fetch
CanonicalWorker-->>AliasWorker: Return response
AliasWorker-->>LegacyClient: Return response
Merge Risk: ⚪ Minimal · up to Clients use the renamed Worker origins, while legacy hostnames continue forwarding and the deployment guard protects Workers that still have Durable Object bindings. No actionable merge-blocking risk remains. Security Architecture ReviewSecurity architecture risk: 🟡 Moderate · up to Legacy clients are intended to reach the same service and stored state through the old hostnames. The forwarding path retains the service’s authentication checks, but the alias deployment check cannot itself confirm that the renamed Workers still own the original storage. The reported live rename provides reassurance; its storage-identity evidence is not available here. Retained concerns
Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
Hardening Proposals
🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 15 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
Target the existing canonical Workers, retain schema 6 on activation while reading v7, require verified staging and compatible rollback metadata, and require explicit Mac admission support. Canonical deployment names follow the existing rename work in manaflow-ai#13768. Co-authored-by: Abdulaziz Albahar <67667005+azooz2003-bit@users.noreply.github.com>
|
Automatic catch-up: I tried to catch this branch up with
Nothing was pushed. Merge Automatic catch-up will not try this head again; a new push or |
…ames # Conflicts: # workers/iroh-v2/README.md # workers/iroh-v2/scripts/deploy-production.sh
|
Automatic catch-up couldn't merge Label |
|
Superseded by the merged rename and compatibility work in #14936. Canonical Workers are now cmux-v2, cmux-v2-staging, and cmux-v2-development; the old cmux-iroh-v2 hostnames remain forwarding aliases for existing clients. |
2 participants
The v2 Workers were named after IROH even though the backend also owns tickets, registration, directory, dashboard, and team control. This renames the canonical Workers to
cmux-v2,cmux-v2-staging, andcmux-v2-development, updates client and dashboard origins, and keeps the old hostnames as Cloudflare service-binding aliases.The live Workers were renamed in place before alias deployment, preserving their Durable Object namespaces and data. Old aliases forward to the canonical Worker, so old app builds continue to reach the same storage. The temporary rename proof also verified SQLite data and an open WebSocket survived the operation.
Validation:
error.v1/unsupported_methodresponses from old and new URLs in all three environments.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Renames the v2 Workers from
cmux-iroh-v2*tocmux-v2,cmux-v2-staging, andcmux-v2-developmentsince the backend also owns tickets, registration, directory, dashboard, and team control. Old hostnames stay as Cloudflare service-binding aliases, so existing app builds keep reaching the same storage.Written for commit d504b48. Summary will update on new commits.
Summary by CodeRabbit
cmux-v2addresses for production, staging, and development.cmux-iroh-v2addresses continue to work and forward requests to the correspondingcmux-v2service, including WebSocket connections.