Repository navigation
ci: pass the R2 cache URL to reusable macOS and iOS workflows - #13684
Merged
Merged
Conversation
#13405 moved the macOS jobs into ci-macos.yml as a called workflow. A called workflow does not inherit the caller's workflow-level env, so CI_CACHE_R2_PUBLIC_URL stopped reaching scripts/ci/r2-cache.sh and every R2 restore in compile admission logs 'CI_CACHE_R2_PUBLIC_URL is not set; treating as a miss'. test-ios.yml has the same gap. Declare it in both. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
teamleaderleo
enabled auto-merge (squash)
September 22, 2026 15:02
|
Warning Review limit reachedNext included review available in 8 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#13405 (09-21 23:30 UTC) moved the macOS jobs into
ci-macos.ymlas a called workflow. A called workflow doesn't inherit the caller's workflow-levelenv, soCI_CACHE_R2_PUBLIC_URL, which is set only inci.ymlandnightly.yml, stopped reachingscripts/ci/r2-cache.sh.Since then, macOS compile admission logs
r2-cache: CI_CACHE_R2_PUBLIC_URL is not set; treating as a missfor both the Swift package cache and the compilation cache. Every PR compile has been cold, even though nightly keeps seeding R2.test-ios.ymlhas the same gap.This declares the variable at workflow level in both files, reading the same
vars.CI_CACHE_R2_PUBLIC_URL.Found while working on #13668, which fixes the same gap for
cli-pipe-regressions.yml. Part of #13095 and #13182.Tests: the guard, persistent-Mac, cache-receipt, shard, product-reuse and iOS dispatch tests that reference these files pass.
test_check_ghostty_zig_workflows.pyandtest_ci_change_areas.pyfail the same way on clean main.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes the R2 cache miss in reusable macOS and iOS workflows so PR compiles hit the cache instead of running cold.
CI_CACHE_R2_PUBLIC_URLstopped reachingscripts/ci/r2-cache.shafter the macOS jobs were moved intoci-macos.yml;test-ios.ymlhas the same gap.CI_CACHE_R2_PUBLIC_URLat workflow level in both files, readingvars.CI_CACHE_R2_PUBLIC_URL.Written for commit 6639c36. Summary will update on new commits.