fix: admit agent renames of agent-owned Cloud names; update pending machine row test - #13654
Conversation
e6926fb (manaflow-ai#13403) made submitCloudPanelRename run admitsTerminalRename for automatic names. Its last clause only admitted replacing an accepted name when the local panel still carried `.auto` provenance, but since 1e1d319 an accepted daemon name reconciles locally as `.remote` and the owner lives in the tab's nameAuthority. Every agent title after the first accepted one was refused, so "Failed agent rename keeps the accepted title", "Mirroring an agent-named placement does not block its next agent title" and "An older automatic result and old snapshots cannot replace an accepted name" failed on their second agentName call. Admit an automatic rename when no write is pending and the accepted tab name is owned by the daemon's `auto` authority. User-owned names, pending writes and local user titles on any projection still refuse it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
manaflow-ai#12919 (021f792) made New Machine creation optimistic: once a running create's machine appears in the fleet list or catalog, its row keeps the `pending-machine:<operation>` node ID so selection and expansion survive adoption (see committedProjectionKeepsThePendingNodeIdentityUntilFleetAdoptsIt). pendingRowStepsAsideOnceItsMachineHasARow still expected `machine:<id>`. Assert the new identity and that the row is the adopted machine, not a stand-in: the stand-in is gone, one row remains, and it shows the created machine. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a91a26c
into
manaflow-ai:fix/app-host-green
Cloud browser, sidebar and naming group for #13643. Failure details are from #13403's CI run 35688876556, the latest completed app-host run (the integration branch's own run stopped at static checks).
Fixed here
admitsTerminalRenameto the automatic path ofsubmitCloudPanelRename. Admission only let an agent replace an accepted name when the local panel still had.autoprovenance. Since 1e1d319, accepted names reconcile as.remoteand the owner is the tab's daemonnameAuthority, so every agent title after the first was refused. Fix: admit when no write is pending and the accepted tab name hasautoauthority. User-owned names, pending writes and local user titles still refuse it.pendingRowStepsAsideOnceItsMachineHasARow(). Stale test. Cloud: make New Machine creation optimistic #12919 (021f792) intentionally keeps a running create'spending-machine:<op>node ID on the adopted machine row. The test now asserts that ID and that the row is.machineshowing the created machine, not a stand-in.Already covered by #13651 (in this branch; waiting on the first app-host run)
The deferred Cloud browser, "Every Cloud website retains its requested URL" (x3), the empty local sidebar group, the captured sidebar row, the tab selection, and the three #13651 checks (MachinesPanelModel project group, "Sidebar and repeated opens…", "Unsupported providers…"). Each failed with
destinationNotFoundor downstream of it.Left
browserPanelRetriesDiscardedRestoreAfterConnectionRefused(). Host dependency. On some runners WebKit's load to the refused loopback port never settles. EvenwebView.stopLoading()leavesisLoadingtrue for 10 s (line 63, added in b3755b8). The pre-b3755b8523 version passed in 17.7 s on runs 35715275879 and 35718469909 and timed out on others. The browser code is unchanged between those runs.visibilityToggleKeepsAppKitTableContainerMounted(). Reveal projects every row twice (10 vs 5). This happens on main-based branches too, since at least 09-20. I couldn't find the cause without an app-host run, so it's not fixed here.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes a Cloud rename admission regression so agent renames of accepted names work again, and updates the pending-machine-row test for the current row identity.
.remotewith the tab's daemonnameAuthority, but admission only replaced accepted names when the local panel still had.autoprovenance, so every agent title after the first was refused.autoauthority; user-owned names, pending writes, and local user titles still refuse.pendingRowStepsAsideOnceItsMachineHasARownow expects the running create'spending-machine:<op>node ID to stay on the adopted machine row and verifies the row shows the created machine, not a stand-in.Written for commit 17381ac. Summary will update on new commits.