Skip to content

fix: admit agent renames of agent-owned Cloud names; update pending machine row test - #13654

Merged
teamleaderleo merged 2 commits into
manaflow-ai:fix/app-host-greenfrom
teamleaderleo:fix/app-host-cloud-sidebar-naming
Sep 22, 2026
Merged

teamleaderleo merged 2 commits into
manaflow-ai:fix/app-host-greenfrom
teamleaderleo:fix/app-host-cloud-sidebar-naming

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Cloud browser, sidebar and naming group for #13643. Failure details are from #13403's CI run 35688876556, the latest completed app-host run (the integration branch's own run stopped at static checks).

Fixed here

  • "Failed agent rename keeps the accepted title and daemon naming authority", "Mirroring an agent-named placement does not block its next agent title" (CloudSidebarRenameReconciliation) and "An older automatic result and old snapshots cannot replace an accepted name" (CloudNameAuthority, the 2 SetAutoTitleSocketTests issues). Product regression from e6926fb (Repair main's full macOS suite: package test compile and app-host regressions #13403 repair). That commit added admitsTerminalRename to the automatic path of submitCloudPanelRename. Admission only let an agent replace an accepted name when the local panel still had .auto provenance. Since 1e1d319, accepted names reconcile as .remote and the owner is the tab's daemon nameAuthority, so every agent title after the first was refused. Fix: admit when no write is pending and the accepted tab name has auto authority. User-owned names, pending writes and local user titles still refuse it.
  • pendingRowStepsAsideOnceItsMachineHasARow(). Stale test. Cloud: make New Machine creation optimistic #12919 (021f792) intentionally keeps a running create's pending-machine:<op> node ID on the adopted machine row. The test now asserts that ID and that the row is .machine showing the created machine, not a stand-in.

Already covered by #13651 (in this branch; waiting on the first app-host run)
The deferred Cloud browser, "Every Cloud website retains its requested URL" (x3), the empty local sidebar group, the captured sidebar row, the tab selection, and the three #13651 checks (MachinesPanelModel project group, "Sidebar and repeated opens…", "Unsupported providers…"). Each failed with destinationNotFound or downstream of it.

Left

  • browserPanelRetriesDiscardedRestoreAfterConnectionRefused(). Host dependency. On some runners WebKit's load to the refused loopback port never settles. Even webView.stopLoading() leaves isLoading true for 10 s (line 63, added in b3755b8). The pre-b3755b8523 version passed in 17.7 s on runs 35715275879 and 35718469909 and timed out on others. The browser code is unchanged between those runs.
  • visibilityToggleKeepsAppKitTableContainerMounted(). Reveal projects every row twice (10 vs 5). This happens on main-based branches too, since at least 09-20. I couldn't find the cause without an app-host run, so it's not fixed here.
  • CloudSidebarNativeDrop already passes.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes a Cloud rename admission regression so agent renames of accepted names work again, and updates the pending-machine-row test for the current row identity.

  • Accepted names reconcile as .remote with the tab's daemon nameAuthority, but admission only replaced accepted names when the local panel still had .auto provenance, so every agent title after the first was refused.
  • Admission now allows an agent rename when no write is pending and the accepted tab name has auto authority; user-owned names, pending writes, and local user titles still refuse.
  • pendingRowStepsAsideOnceItsMachineHasARow now expects the running create's pending-machine:<op> node ID to stay on the adopted machine row and verifies the row shows the created machine, not a stand-in.

Written for commit 17381ac. Summary will update on new commits.

Review in cubic

teamleaderleo and others added 2 commits September 22, 2026 09:30
e6926fb (manaflow-ai#13403) made submitCloudPanelRename run admitsTerminalRename
for automatic names. Its last clause only admitted replacing an accepted
name when the local panel still carried `.auto` provenance, but since
1e1d319 an accepted daemon name reconciles locally as `.remote` and the
owner lives in the tab's nameAuthority. Every agent title after the first
accepted one was refused, so "Failed agent rename keeps the accepted title",
"Mirroring an agent-named placement does not block its next agent title" and
"An older automatic result and old snapshots cannot replace an accepted name"
failed on their second agentName call.

Admit an automatic rename when no write is pending and the accepted tab name
is owned by the daemon's `auto` authority. User-owned names, pending writes and
local user titles on any projection still refuse it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
manaflow-ai#12919 (021f792) made New Machine creation optimistic: once a running
create's machine appears in the fleet list or catalog, its row keeps the
`pending-machine:<operation>` node ID so selection and expansion survive
adoption (see committedProjectionKeepsThePendingNodeIdentityUntilFleetAdoptsIt).
pendingRowStepsAsideOnceItsMachineHasARow still expected `machine:<id>`.

Assert the new identity and that the row is the adopted machine, not a
stand-in: the stand-in is gone, one row remains, and it shows the created
machine.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@teamleaderleo teamleaderleo changed the title test: repair Cloud naming and pending machine row app-host tests fix: admit agent renames of agent-owned Cloud names; update pending machine row test Sep 22, 2026
@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 31ebe583-4275-44f1-8a0a-1dba4b90fab1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@teamleaderleo
teamleaderleo merged commit a91a26c into manaflow-ai:fix/app-host-green Sep 22, 2026
36 checks passed
@teamleaderleo
teamleaderleo deleted the fix/app-host-cloud-sidebar-naming branch September 23, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant