Skip to content

ci: remove agent review gate re-added by #13545 - #13641

Merged
teamleaderleo merged 1 commit into
mainfrom
ci/remove-readded-review-gate
Sep 22, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
ci/remove-readded-review-gate

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

@lawrencecchen removed the agent PR review gate as obsolete in 4d7a70d. It came back by accident:

  1. ci: pin agent review checker to trusted workflow commit #13545 was cut before that removal. Its squash merge 47 minutes later restored every gate file.
  2. The original Agent PR review gate workflow was then disabled in Actions.
  3. I didn't know about the removal. fix: resume agent review workflow triggers #13623 treated the disabled workflow as a trigger bug, and ci: re-register agent review workflow #13628 re-registered it as Agent PR review gate v2, which routed around the disable.

The result is a failing agent-pr-review-complete check on every PR. It isn't a required check. The Greptile request step fails on every run, and Greptile hasn't responded in this repo since about 19:35 UTC on 09-21 anyway.

This PR restores the removal. It deletes both gate workflows, the checker script, its tests, and .github/review-bot-rules/agent-pr-review-gate.md. The PR template and CLAUDE.md edits from 4d7a70d are still in place.

Sorry for the churn, Lawrence. If you think any part of the gate is worth keeping, I'll bring it back only with your OK.

Testing

  • git grep agent-pr-review returns nothing after the deletion.
  • Once this merges, new PRs should no longer get an agent-pr-review-complete check.
  • A maintainer can also delete the orphaned, disabled Agent PR review gate workflow entry in Actions.

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Restores the removal of the obsolete agent PR review gate, which #13545's squash merge accidentally re-added and brought back a failing agent-pr-review-complete check on every PR.

Deletes both gate workflows (agent-pr-review-gate.yml and agent-pr-review-gate-v2.yml), the checker script, its tests, and the gate rule doc.

Written for commit 540a573. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Removals
    • Removed the automated agent PR review gate from repository workflows.
    • Removed automatic review requests, review coverage checks, response tracking, and attention-label synchronization.
    • Removed documentation and automated tests covering the agent review gate.

4d7a70d removed the agent PR review gate as obsolete. #13545 was cut
before that removal, and its squash merge restored every gate file. The
original workflow was then disabled in Actions, and #13623/#13628 re-registered
it as "Agent PR review gate v2". That brought back a failing
agent-pr-review-complete check on every PR.

Restore the removal: delete both gate workflows, the checker script, its
tests, and the gate rule doc.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits. You can see your limits in the Codex usage dashboard.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b2d138fe-14ae-4e9f-820b-37ec8b4a2b56

📥 Commits

Reviewing files that changed from the base of the PR and between c08825b and 540a573.

📒 Files selected for processing (5)
  • .github/review-bot-rules/agent-pr-review-gate.md
  • .github/scripts/agent-pr-review-gate.py
  • .github/workflows/agent-pr-review-gate-v2.yml
  • .github/workflows/agent-pr-review-gate.yml
  • tests/test_agent_pr_review_gate.py
💤 Files with no reviewable changes (5)
  • .github/scripts/agent-pr-review-gate.py
  • tests/test_agent_pr_review_gate.py
  • .github/review-bot-rules/agent-pr-review-gate.md
  • .github/workflows/agent-pr-review-gate-v2.yml
  • .github/workflows/agent-pr-review-gate.yml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The PR removes the agent PR review gate documentation, checker script, two GitHub Actions workflows, and associated test suite.

Changes

Agent PR review gate removal

Layer / File(s) Summary
Gate contract and checker
.github/review-bot-rules/agent-pr-review-gate.md, .github/scripts/agent-pr-review-gate.py
The gate contract and checker are deleted. The removed checker previously evaluated current-head review coverage, reply obligations, Greptile requests, labels, and gate output.
Workflow and validation removal
.github/workflows/agent-pr-review-gate.yml, .github/workflows/agent-pr-review-gate-v2.yml, tests/test_agent_pr_review_gate.py
Both gate workflows and the test suite are deleted. The workflows previously triggered gate evaluation and Greptile review requests. The tests previously covered the checker behavior and workflow wiring.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 540a5

This change removes the failing agent review gate and its associated enforcement artifacts; no concrete production risk remains identified, so it is mergeable with normal checks.

🚥 Pre-merge checks | ✅ 25
✅ Passed checks (25 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Cmux Cloud Persistent Session And Early Input ✅ Passed PASS. The authoritative diff changes only agent review-gate documentation, script, workflows, and tests. It contains no Cloud terminal creation, persistent transport, renderer, input-routing, snapshot…
Cmux Swift Actor Isolation ✅ Passed PASS: The reviewed diff deletes five non-Swift CI, script, documentation, and test files. It contains no changed .swift paths, so it introduces no Swift actor isolation issue.
Cmux Swift Blocking Runtime ✅ Passed The pull request changes only five non-Swift files, all by deletion. The diff has 0 added lines and no changed Swift path, so it does not introduce or expand blocking or timing-based synchronization i…
Cmux Browser Automation Off-Main ✅ Passed The PR changes only the agent review gate documentation, script, workflows, and tests, all by deletion. No browser automation paths or browser/WebKit/socket routing code changed, and the browser-autom…
Cmux Expensive Synchronous Load ✅ Passed The authoritative diff contains only deletions of two review workflows, the Python gate script, its documentation, and its tests. It changes no production Swift files and adds or moves no synchronous …
Cmux Cache Substitution Correctness ✅ Passed PASS: The authoritative PR diff deletes only Markdown, Python, YAML workflow, and Python test files. It contains no production Swift, TypeScript, or JavaScript change, so the cache substitution condit…
Cmux No Hacky Sleeps ✅ Passed PASS: The PR only deletes the agent review documentation, Python gate script, two GitHub Actions workflows, and tests. The authoritative diff has 0 additions and 1,275 deletions, with no changed TypeS…
Cmux Algorithmic Complexity ✅ Passed The authoritative PR diff contains only deletions: the agent review script, two workflows, its test file, and its rule document. It adds or modifies no production Swift, TypeScript, JavaScript, shell,…
Cmux Swift Concurrency ✅ Passed The reviewed range changes only five non-Swift files, and all changes are deletions. It introduces no cmux-owned Swift code or legacy Swift concurrency pattern.
Cmux Swift @Concurrent ✅ Passed PASS: The pull request changes only Markdown, Python, YAML, and test files. The authoritative diff contains no Swift files or Swift code, so the @concurrent check is not applicable.
Cmux Swift Package Boundaries ✅ Passed The pull request changes only two workflow files, one Python checker, its Python tests, and a Markdown rule document. The authoritative diff contains no Swift, SwiftPM, or app-target files. Therefore,…
Cmux Swiftpm Lockfiles ✅ Passed The PR only deletes agent-review documentation, a Python checker, two agent-review workflows, and their tests. It does not change Package.swift, Package.resolved, .gitignore, Xcode project references,…
Cmux Swift Logging ✅ Passed PASS: The authoritative PR diff changes only five gate documentation, Python, workflow, and test files. It contains no Swift or other production Swift logging changes, so the Swift logging criteria do…
Cmux User-Facing Error Privacy ✅ Passed PASS: The authoritative PR diff contains only deletions in review-bot documentation, GitHub Actions workflows, a CI script, and tests. It adds or modifies no user-facing errors, alerts, command output…
Cmux Full Internationalization ✅ Passed PASS. The authoritative diff contains only deletions: two GitHub Actions workflows, a CI script, an operational review-rule document, and tests. It adds zero lines and changes no Swift, web UI, locale…
Cmux Swiftui State Layout ✅ Passed PASS: The pull request changes only agent-review workflow, script, documentation, and test files. The authoritative diff contains no Swift, SwiftUI, Xcode, or iOS paths and no Swift content changes. T…
Cmux Architecture Rethink ✅ Passed The pull request changes only CI/review-gate documentation, Python, YAML, and test files. The authoritative diff contains no Swift files or Swift architecture changes, so the Swift architectural rethi…
Cmux Swift Auxiliary Window Close Shortcuts ✅ Passed The pull-request diff contains only deletions of review-gate documentation, Python, workflow, and test files. It contains no Swift or window-related changes, so the auxiliary-window close-shortcut che…
Cmux Source Artifacts ✅ Passed The pull request changes only five existing files, and the authoritative diff shows 0 additions for every path. All changes are full deletions of review documentation, a script, workflows, and tests. …
Cmux No Test Or Debug Seam In Production Source ✅ Passed PASS: The authoritative PR diff changes only five deleted Markdown, Python, YAML, and test files. It contains no changed Swift files and no paths under a production Sources/ directory, so the custom…
Title check ✅ Passed The title clearly and concisely describes the main change: removing the reintroduced agent review gate.
Description check ✅ Passed The description explains what changed, why it changed, and how it was tested. It omits the template checklist and review-trigger block, but the core information is complete and the change is not a UI …
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant