Skip to content

Test installed Codex hooks through queue persistence - #13631

Merged
teamleaderleo merged 1 commit into
mainfrom
chatgpt/issue-13489-queue-persistence-regression
Sep 22, 2026
Merged

teamleaderleo merged 1 commit into
mainfrom
chatgpt/issue-13489-queue-persistence-regression

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Adds regression coverage for #13489 across the source seam that was previously split between separate tests.

The test now exercises:

  1. cmux hooks codex install --yes
  2. the generated persistent SessionStart / UserPromptSubmit shell commands
  3. the real bundled CLI's hooks enqueue codex ... admission path
  4. PID-based agent.resolve_delivery_target route snapshotting
  5. AgentHookDeliveryQueue + AgentHookDeliveryProcess replay
  6. persistence into codex-hook-sessions.json

It asserts the persisted session keeps the expected session id, workspace id, surface id, PID, running state, and prompt turn.

Why

The product fix already landed in #8537 (fbcdd8dc71d6dbbff0e46c9d82b3ed7e7c66bfa4). Existing coverage verifies the installed shell reaches queue admission, and separate tests verify the direct Codex handler persists sessions. There was no regression joining those two halves, which is the exact boundary implicated by #13489.

This PR is test-only; no product behavior changes.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Adds regression coverage for #13489 by joining the two previously split test halves into one end-to-end test.

  • Installs the Codex hooks, replays the generated SessionStart and UserPromptSubmit commands through the real bundled CLI admission path and delivery queue, and asserts the persisted codex-hook-sessions.json record keeps session ID, workspace ID, surface ID, PID, running state, and prompt turn.
  • Test-only; no product behavior changes.

Written for commit 0464f23. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 76bab838-f55f-4672-a6cb-856c6f56397b

📥 Commits

Reviewing files that changed from the base of the PR and between 121bf02 and 0464f23.

📒 Files selected for processing (1)
  • cmuxTests/AgentHookDeliveryQueueTests.swift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@teamleaderleo
teamleaderleo merged commit 6191108 into main Sep 22, 2026
46 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant