Repository navigation
Test installed Codex hooks through queue persistence - #13631
Merged
teamleaderleo merged 1 commit intoSep 22, 2026
Merged
Conversation
|
Warning Review limit reachedNext included review available in 28 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds regression coverage for #13489 across the source seam that was previously split between separate tests.
The test now exercises:
cmux hooks codex install --yesSessionStart/UserPromptSubmitshell commandshooks enqueue codex ...admission pathagent.resolve_delivery_targetroute snapshottingAgentHookDeliveryQueue+AgentHookDeliveryProcessreplaycodex-hook-sessions.jsonIt asserts the persisted session keeps the expected session id, workspace id, surface id, PID, running state, and prompt turn.
Why
The product fix already landed in #8537 (
fbcdd8dc71d6dbbff0e46c9d82b3ed7e7c66bfa4). Existing coverage verifies the installed shell reaches queue admission, and separate tests verify the direct Codex handler persists sessions. There was no regression joining those two halves, which is the exact boundary implicated by #13489.This PR is test-only; no product behavior changes.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds regression coverage for #13489 by joining the two previously split test halves into one end-to-end test.
SessionStartandUserPromptSubmitcommands through the real bundled CLI admission path and delivery queue, and asserts the persistedcodex-hook-sessions.jsonrecord keeps session ID, workspace ID, surface ID, PID, running state, and prompt turn.Written for commit 0464f23. Summary will update on new commits.