Repository navigation
Restore Ghostty Pure prompt redraw fix - #1363
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ghostty submodule pointer and documentation were updated to reference a new fork commit (404a3f1) that fixes Pure-style zsh prompt redraw markers; no functional code, public APIs, or control flow were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 099f0a931a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ghostty`:
- Line 1: The ghostty submodule pointer references commit
099f0a931ae0538051d9adba98cef8bc6986f5d1 which is not present on the remote main
branch; push that commit to the manaflow-ai/ghostty remote main branch first
(ensure the commit is part of origin/main on the ghostty repo), then update the
submodule pointer in the parent repo (the ghostty entry) and amend the PR so the
parent repo references the now-published main commit.
|
Addressed the Ghostty submodule review threads.
|
…e-prompt-followup Restore Ghostty Pure prompt redraw fix
This branch was successfully deployed
1 participant
Summary
manaflow-ai/ghosttymainxcframework-404a3f175ba6baafabc46cac807194883e040980release is publishedTesting
python3 tests/test_ghostty_zsh_pure_hidden_cr_omits_continuation_marker.pypython3 tests/test_ghostty_zsh_pure_preprompt_redraw.pypython3 tests/test_shell_zsh_prefers_bundled_ghostty_integration.pypure-followuppassedscripts/probe-pure-prompt-duplication.pyagainst a minimal Pure repro homeDependency
Checklist
manaflow-ai/ghosttymain