Repository navigation
CI: stop unnecessary Release builds and gate paid runner - #13629
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (8)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe workflow now admits Release builds only after successful Linux preflight. The CI classifier excludes open-wrapper runtime and test changes from Release builds while retaining macOS coverage. Tests verify both behaviors. ChangesRelease build CI controls
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant linux-preflight
participant release-admission
participant GitHubActionsAPI
participant release-build
linux-preflight->>GitHubActionsAPI: publish job conclusion
release-admission->>GitHubActionsAPI: poll workflow jobs
GitHubActionsAPI-->>release-admission: return linux-preflight conclusion
release-admission->>release-build: admit only when conclusion is success
Merge Risk: ⚪ Minimal · up to This change gates Release builds on Linux preflight and avoids unnecessary builds for open-wrapper-only changes. It is ready to merge. 🚥 Pre-merge checks | ✅ 23 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (23 passed)
Full details: Description checkExplanation The description clearly explains the CI routing change, the release admission gate, and the reason for the change. However, it omits the required Testing section and repository checklist, including local testing, documentation, review, and comment-resolution status. Resolution Add the required Testing section with commands and verification results. Add the complete Checklist and mark each item accurately. Include the Review Trigger section or explain its status. Demo Video is not required unless this change is considered a behavior change requiring a demonstration. Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
842875a to
849ff07
Compare
|
@greptileai review |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
1 participant
What changed
Resources/bin/openandtests/test_open_wrapper.pyas Release-build-neutral CI inputs.xcodebuild -configuration Releaselane.release-admissionjob in the reusable macOS workflow.linux-preflightverdict.Why
Run https://github.com/manaflow-ai/cmux/actions/runs/35689908387 exposed both problems:
openwrapper plus its regression test, yet CI routed it intomacos / release-build.This keeps the existing macOS compile/test concurrency while preventing the universal Release build from starting unless the cheap routed CI verdict is green.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Stops CI from queueing product work that can't catch anything new:
openwrapper-only changes skip the universal Release build, the paid macOS Release runner is gated on a green Linux preflight, and routing-policy-only PRs run no product-area CI.Release builds
Resources/bin/openandtests/test_open_wrapper.pychanges still route through macOS validation but no longer queue the universalxcodebuild -Configuration Releaselane.release-admissionjob waits forlinux-preflightand blocks the paid macOS 26 Release runner when the guard/web/preflight result is red.Queued work
ci.ymledits that only change macOS jobs.workflow-guard-tests;ci-macos.ymledits that only change Release jobs run just the release-related guard groups, andweb-complexityworkflow edits run only thecigroup.changesjob skips macOS compile admission when the app-host build-input fingerprint matchesHEAD^1.web-complexityonly queues forweb/**paths, andweb-complexity-trustedscopes pull requests from the GitHub file list before web setup, so it no longer retriggers on PR metadata edits or ready-state flips.Written for commit d28a4d3. Summary will update on new commits.
Summary by CodeRabbit
Bug Fixes
Tests