Repository navigation
test(iOS): isolate preview-text reconfigure route - #13612
teamleaderleo wants to merge 1 commit into
Conversation
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing as superseded by #13607, which already landed the exact preview-text-only test fix plus the macOS-neutral routing carve-out on |
Fixes #13563.
previewTextChangeReconfiguresInPlaceWithoutTableReload()was mutating bothpreviewTextandhasUnread, while the coordinator intentionally treatshasUnreadtransitions as native-action payload changes that take the table-reload path.This removes only the unrelated unread mutation so the test exercises the route named by the test: a preview-text-only payload change should reconfigure the visible row in place. Unread/native-action behavior remains covered by
workspaceReloadsNativeActionsWhenReadStateChanges().Evidence:
.tableReloadwhile this test expected.reconfiguredInPlace(["workspace.workspace-1"])mainalready classifiesPackages/iOS/CmuxMobileShellUI/Tests/**as macOS-neutral, so this test-only PR should stay off the generic macOS compile routeFocused simulator verification can use:
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes #13563.
previewTextChangeReconfiguresInPlaceWithoutTableReload()was mutating bothpreviewTextandhasUnread, but the coordinator treats unread transitions as native-action changes that force a table reload. This removes only the unrelated unread mutation so the test exercises the preview-text-only route, which should reconfigure the row in place.workspaceReloadsNativeActionsWhenReadStateChanges().Written for commit 0e3aef9. Summary will update on new commits.
Summary by CodeRabbit