Skip to content

test(iOS): isolate preview-text reconfigure route - #13612

Closed
teamleaderleo wants to merge 1 commit into
mainfrom
fix/13563-preview-route-test
Closed

teamleaderleo wants to merge 1 commit into
mainfrom
fix/13563-preview-route-test

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #13563.

previewTextChangeReconfiguresInPlaceWithoutTableReload() was mutating both previewText and hasUnread, while the coordinator intentionally treats hasUnread transitions as native-action payload changes that take the table-reload path.

This removes only the unrelated unread mutation so the test exercises the route named by the test: a preview-text-only payload change should reconfigure the visible row in place. Unread/native-action behavior remains covered by workspaceReloadsNativeActionsWhenReadStateChanges().

Evidence:

  • failing iPhone run: https://github.com/manaflow-ai/cmux/actions/runs/35682638589
  • failure observed .tableReload while this test expected .reconfiguredInPlace(["workspace.workspace-1"])
  • a later unchanged-iOS main run passed, exposing the test as nondeterministic/conflicted with the explicit unread reload contract
  • current main already classifies Packages/iOS/CmuxMobileShellUI/Tests/** as macOS-neutral, so this test-only PR should stay off the generic macOS compile route

Focused simulator verification can use:

gh workflow run test-ios.yml \
  --ref main \
  -f ref=0e3aef9679783e09065a6a7b2b4a6ad96d24e4e4 \
  -f test_filter=CmuxMobileShellUITests/WorkspaceListScrollUpdateTests \
  -f device_family=iphone \
  -f runner=auto

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Fixes #13563.

previewTextChangeReconfiguresInPlaceWithoutTableReload() was mutating both previewText and hasUnread, but the coordinator treats unread transitions as native-action changes that force a table reload. This removes only the unrelated unread mutation so the test exercises the preview-text-only route, which should reconfigure the row in place.

  • Unread/native-action behavior remains covered by workspaceReloadsNativeActionsWhenReadStateChanges().

Written for commit 0e3aef9. Summary will update on new commits.

Review in cubic

Summary by CodeRabbit

  • Tests
    • Updated workspace list coverage to verify that preview text changes are applied in place without reloading the table.

@cursor

cursor Bot commented Sep 22, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@github-actions

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: manaflow-ai/cmux/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: df0d910a-12c3-4351-a587-4455841f3c8f

📥 Commits

Reviewing files that changed from the base of the PR and between 9c59b59 and 0e3aef9.

📒 Files selected for processing (1)
  • Packages/iOS/CmuxMobileShellUI/Tests/CmuxMobileShellUITests/WorkspaceListScrollUpdateTests.swift
 ________________________
< Code review is my jam. >
 ------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #13607, which already landed the exact preview-text-only test fix plus the macOS-neutral routing carve-out on main (9c59b5914b19ec2f9146df14aed1489f4535679c). This PR now has an empty effective diff, which is why CI failed open and queued every area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS WorkspaceListScrollUpdateTests preview reconfigure test flakes on iPhone simulator

1 participant