Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ import UIKit
coordinator.attach(to: tableView)

workspace.previewText = "Agent finished: PR opened"
workspace.hasUnread = true
coordinator.update(configuration: configuration(workspaces: [workspace]), in: tableView)

#expect(
Expand Down
5 changes: 5 additions & 0 deletions scripts/ci/detect_ci_change_areas.py
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,11 @@ def is_agent_session_web_change(path: str) -> bool:
def is_macos_neutral(path: str) -> bool:
if path in CI_CONTROL_PLANE_ONLY:
return True
# CmuxMobileShellUI is an iOS-only package and its Tests target is exercised
# by test-ios.yml, not by the macOS Swift-package lane. Test-only edits here
# cannot affect desktop product bytes or macOS package tests.
if path.startswith("Packages/iOS/CmuxMobileShellUI/Tests/"):
return True
# `cmux-tui/` is the standalone cmux-tui Rust project, gated by its own
# workflow. Packages/iOS stays macOS-relevant because the desktop app
# links CmuxMobileRPC, CmuxMobileTransport, and their package dependencies.
Expand Down
3 changes: 3 additions & 0 deletions scripts/ci/workflow_guard_groups.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
"Test XCStrings catalog lint": "preflight",
"Test macOS localization catalog tooling": "preflight",
"Test review fabric contracts": "preflight",
"Set up Python 3.9 for nightly prune compatibility": "release-tooling",
"Validate Blacksmith Testbox broker trust boundary": "ci",
"Validate build graph health tooling": "preflight",
"Validate CI Xcode selection fast path": "release-notary",
"Validate CI change area filter": "ci",
"Validate CMUX INTERNAL main-push path filter": "release-ios",
Expand Down Expand Up @@ -175,6 +177,7 @@
"tests/test_bash_integration_no_done_notifications.py": frozenset(("quality-determinism",)),
"tests/test_benchmark_dev_fleet_warm_slots.py": frozenset(("preflight",)),
"tests/test_build_app_bundled_resources.sh": frozenset(("quality-runtime",)),
"tests/test_build_graph_health.py": frozenset(("preflight",)),
"tests/test_build_metrics.py": frozenset(("ci",)),
"tests/test_ci_app_host_failure_census.py": frozenset(("app-host-process",)),
"tests/test_ci_app_host_guard_structure.py": frozenset(("ci",)),
Expand Down
9 changes: 9 additions & 0 deletions tests/test_ci_linux_guard_routing.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

from test_ci_change_areas import (
linux_preflight_needs,
module,
run_guard_status,
run_linux_preflight,
run_tests_gate,
Expand Down Expand Up @@ -59,6 +60,14 @@ def route(paths, event="pull_request", macos="false"):


class LinuxGuardRoutingTests(unittest.TestCase):
def test_ios_shell_ui_test_only_change_skips_macos(self):
actual = module.classify_files([
"Packages/iOS/CmuxMobileShellUI/Tests/CmuxMobileShellUITests/WorkspaceListScrollUpdateTests.swift"
])
self.assertFalse(actual.macos)
self.assertFalse(actual.web)
self.assertFalse(actual.release_build)

def test_candidate_router_cannot_disable_its_own_guards(self):
script = workflow_job_step_script("changes", "Route Linux guard suites")
for changed in (
Expand Down
Loading