Repository navigation
CI: route tagged iOS entitlement guard to release-ios - #13556
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe workflow now runs the tagged iOS device entitlement fallback validation for the ChangesiOS release guard routing
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The guard now runs under the intended release-ios group, with matching structural coverage. It is ready to merge. 🚥 Pre-merge checks | ✅ 24 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (24 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The current release-guard split moved release checks from the retired
releasegroup intorelease-ios,release-notary, andrelease-tooling, but the tagged iOS device entitlement fallback step was left behind onmatrix.group == 'release'.That makes the current structural contract fail:
tests/test_ci_release_guard_structure.pyexplicitly rejects any remaining legacyreleasegroup.This patch:
Validate tagged iOS device entitlement fallbacktorelease-ios;No peer transport or app-host artifact behavior is changed here. This was surfaced while validating #13540 against current main and is split out so that PR can remain scoped.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Fixes the tagged iOS device entitlement fallback guard so it runs under
release-iosinstead of the retiredreleasegroup, and records it in the release-ios ownership map.Written for commit 7fb2206. Summary will update on new commits.
Summary by CodeRabbit
Bug Fixes
Tests