Skip to content

Restore profile menu opening animation #13295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austinywang merged 9 commits into from
Sep 21, 2026
Merged

Restore profile menu opening animation #13295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
786148c
test: cover grouped profile popover opening animation
austinywang Sep 21, 2026
a098fef
fix: restore native profile menu opening animation
austinywang Sep 21, 2026
f46d0ad
fix: keep popover animation policy on coordinator
austinywang Sep 21, 2026
87ee48e
fix: restore SwiftUI test import
austinywang Sep 21, 2026
29444a0
fix: retain closing popover until callback
austinywang Sep 21, 2026
9d5052c
fix: assign coordinator popover property explicitly
austinywang Sep 21, 2026
e80089f
fix: avoid binding writes during popover teardown
austinywang Sep 21, 2026
f10ca36
fix: retain overlapping closing popovers
austinywang Sep 21, 2026
331c576
Merge branch 'main' into 13294-profile-menu-animation
austinywang Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ages/macOS/CmuxAppKitSupportUI/Sources/CmuxAppKitSupportUI/Popover/CmuxPopoverGroup.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ public final class CmuxPopoverGroup {
contains: contains,
containsPointer: containsPointer,
close: { [weak popover] in
// Finish each child's close before its parent tears down its window.
popover?.animates = false
popover?.close()
}
Expand Down
1 change: 1 addition & 0 deletions Sources/SidebarAccountTeamPopover.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ struct SidebarAccountMenuButton: View {
isPresented: $isPopoverPresented,
preferredEdge: .maxY,
detachedGap: 4,
presentationAnimation: .enabled,
group: popoverGroup
) {
SidebarAccountPopover(
Expand Down
Loading