Repository navigation
feat(settings): expose automation rules - #13223
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 33 minutes. View limit detailsLimit details: You’ve used all 10 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: manaflow-ai/cmux/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
All contributors have signed the CLA ✍️ ✅ |
|
This comment has been minimized.
This comment has been minimized.
|
Addressed the outside-diff compilation finding in 2a7f663: removed the duplicate dangling .task modifiers following refreshAutomationRulesStatus(); the existing view body retains the observation and policy tasks. Also declared defaultLocalization: "en" for the package resources added by this PR. Swift frontend parsing passes for AutomationSection, HostSettingsActions and its behavior tests. Full app/package/unit CI remains required; this is not yet a dogfood or merge-readiness claim. |
Kept both sides: automation-rules host actions next to main's custom-sidebar actions, the automation config parameters next to main's computersActions/runComputerUseOnboardingAction init parameters, and both package resources (the Settings UI string catalog and main's CustomSidebars copy). This branch's tests now pass the onboarding action main made required. Localizable.xcstrings: main's catalog plus this branch's two new keys. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Reviewer summary
Surfaces automation rules in Settings with their current status and controls, using the existing automation owner.
What changed
AutomationConfigStore~/.cmuxterm/automations.jsonthrough the existing preferred-editor serviceAutomationEnginepathcmux automationimplementationTests
Upstream base SHA:
4c67b4d8c59bc395ba2b75dc66bd688e5b846a6dTact Lane E: teamleaderleo/Tact#79
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Adds an Automation Rules card to Settings > Automation so rule counts and config status are visible without leaving Settings.
~/.cmuxterm/automations.jsonwhen missing, then opens it in the preferred editor; creation failures show actionable guidance.CmuxSettingsUI; adds host and UI coverage for counts, errors, actions, reload routing, and localization.Written for commit f90c43f. Summary will update on new commits.
Summary by CodeRabbit
New Features
Tests
Replaces #13038 (same commits, head branch moved into the org so it gets the build cache and can be kept current with main).
🤖 Generated with Claude Code